Reject masked update diagnostic integers#4492
Merged
FlorianPfaff merged 2 commits intoJul 17, 2026
Merged
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
FlorianPfaff
marked this pull request as ready for review
July 17, 2026 13:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bug
MeasurementUpdateDiagnosticsvalidatesactive_measurement_indicesandmeasurement_countthroughoperator.index. NumPy masked integer scalars expose their hidden payload to that conversion, so a genuinely missing value such asnp.ma.array(7, mask=True)was silently accepted as the integer7.This can make diagnostics report measurements as active, or accept a measurement count, based on inaccessible masked data.
Fix
MaskedArrayinteger scalars whose mask is falseValidation
operator.index(np.ma.array(7, mask=True)) == 7before the fixmain, 0 behind; only the diagnostics helper and its validation test changedThe full repository CI matrix should provide integration and backend coverage.