refactor(tabs): simplify Tabs API and migrate plain-text labels#7386
Draft
talissoncosta wants to merge 2 commits intofeat/storybook-component-storiesfrom
Draft
refactor(tabs): simplify Tabs API and migrate plain-text labels#7386talissoncosta wants to merge 2 commits intofeat/storybook-component-storiesfrom
talissoncosta wants to merge 2 commits intofeat/storybook-component-storiesfrom
Conversation
- Drop dead overflowX prop and stop applying className twice (outer .tabs and inner .tabs-nav both received the same className) - Add getLabelString helper so tabLabelString is only required for JSX labels; strings derive automatically - Migrate 11 sites from `<Row className='justify-content-center'>Foo</Row>` wrappers to plain `tabLabel='Foo'`, dropping 5 redundant tabLabelString declarations alongside Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The IIFE introduced when satisfying lint-staged was hard to read; lift it to a
let so the button body is just {saveLabel}.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
the
front-end
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
Changes
Contributes to #6606 (Design System Audit). First in a stack of three Tabs PRs that, taken together, decouple the Tabs component from domain and routing concerns.
This PR is the smallest of the stack — pure cleanup, no new behaviour.
Stack:
How did you test this code?
Manually verified:
Stories already on `feat/storybook-component-stories` cover the basic Tabs / PillTheme variants.