refactor: create feature migration by kyle-ssg · Pull Request #6925 · Flagsmith/flagsmith

kyle-ssg · 2026-03-11T15:21:57Z

Thanks for submitting a PR! Please check the boxes below:

I have read the Contributing Guide.
I have added information to docs/ if required so people know about the feature.
I have filled in the "Changes" section below.
I have filled in the "How did you test this code" section below.

Changes

Migrates all tabs including the create feature modal itself to TypeScript, no type errors to do with creating / editing a feature and also reduces the feature modal by ~1200 LoC.

Migrates a few components to ES export

How did you test this code?

E2E was extended to cover more of the feature management process specifically for this PR
Created / edited features in production

…ure-state-view-unified

Co-authored-by: Zaimwa9 <wadii.zaim@flagsmith.com>

…ent-feature-state-view # Conflicts: # frontend/web/components/feature-page/FeatureFilters.tsx # frontend/web/components/pages/FeaturesPage.js # frontend/web/components/pages/UserPage.tsx # frontend/web/components/tables/TableValueFilter.tsx

Co-authored-by: Zaimwa9 <wadii.zaim@flagsmith.com>

…ent-feature-state-view # Conflicts: # frontend/web/components/modals/AssociatedSegmentOverrides.js

…ent-feature-state-view

vercel · 2026-03-11T15:22:02Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
flagsmith-frontend-preview	Ready	Preview, Comment	Mar 18, 2026 9:34am
flagsmith-frontend-staging	Ready	Preview, Comment	Mar 18, 2026 9:34am

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Ignored	Preview	Mar 18, 2026 9:34am

github-actions · 2026-03-11T15:23:16Z

Docker builds report

Image	Build Status	Security report
`ghcr.io/flagsmith/flagsmith-api-test:pr-6925`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-api:pr-6925`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-e2e:pr-6925`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith:pr-6925`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-private-cloud:pr-6925`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-frontend:pr-6925`	Finished ✅	Results ✅

github-actions · 2026-03-11T15:29:53Z

Playwright Test Results (oss - depot-ubuntu-latest-16)

10 passed

Details

10 tests across 7 suites
11.9 seconds
f1c6066
🔄 Run: #15242 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

10 passed

Details

10 tests across 7 suites
48 seconds
f1c6066
🔄 Run: #15242 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

16 passed

Details

16 tests across 13 suites
1 minute, 7 seconds
f1c6066
🔄 Run: #15242 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

10 passed

Details

10 tests across 7 suites
48.9 seconds
ba41b02
🔄 Run: #15243 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

10 passed

Details

10 tests across 7 suites
49.5 seconds
ba41b02
🔄 Run: #15243 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

1 passed

Details

1 test across 1 suite
1 minute, 17 seconds
f1c6066
🔄 Run: #15242 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
54.2 seconds
ba41b02
🔄 Run: #15243 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

2 passed

Details

2 tests across 2 suites
1 minute, 2 seconds
ba41b02
🔄 Run: #15243 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

10 passed

Details

10 tests across 7 suites
46.5 seconds
c99dff2
🔄 Run: #15330 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

10 passed

Details

10 tests across 7 suites
48.8 seconds
c99dff2
🔄 Run: #15330 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
54.9 seconds
c99dff2
🔄 Run: #15330 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

2 passed

Details

2 tests across 2 suites
1 minute, 2 seconds
c99dff2
🔄 Run: #15330 (attempt 1)

talissoncosta · 2026-03-11T20:53:04Z

frontend/web/components/modals/create-feature/tabs/IdentityOverridesTab.tsx

+        const envId = project?.environments?.find(
+          (env) => env.api_key === environmentId,
+        )?.id
+        if (!envId) {
+          setUserOverridesNoPermissionState()
+          return
+        }


I think I might have found a bug

This is comparing api_key (a string like "RAvjEqbj96SXiJP4hQHd5E") with environmentId which is now a numeric ID (e.g. "123") after #6322. They'll never match, so it always falls into the no-permission state.

environmentId is already the numeric ID, so this lookup can be removed and environmentId passed directly to getPermission.

I am getting this:

talissoncosta · 2026-03-11T20:57:01Z

frontend/web/components/modals/create-feature/tabs/IdentityOverridesTab.tsx

+        getPermission(
+          getStore(),
+          {
+            id: envId,
+            level: 'environment',
+          },
+          { forceRefetch },
+        )


Suggested change

getPermission(

getStore(),

{

id: envId,

level: 'environment',

},

{ forceRefetch },

)

getPermission(

getStore(),

{

id: environmentId,

level: 'environment',

},

{ forceRefetch },

)

it seems to do the trick

talissoncosta · 2026-03-11T21:18:55Z

frontend/web/components/modals/create-feature/tabs/SegmentOverridesTab.tsx

+  const environment = project?.environments?.find(
+    (env) => env.api_key === environmentId,
+  )


Same api_key vs numeric ID issue as above — environment is always undefined, so isVersioned and is4Eyes are always false. This silently bypasses 4-eyes/change requests for segment overrides.

Suggested change

const environment = project?.environments?.find(

(env) => env.api_key === environmentId,

)

const environment = getEnvironment(environmentId)

frontend/web/components/modals/create-feature/tabs/IdentityOverridesTab.tsx

…rridesTab.tsx Co-authored-by: Talisson <talisson.odcosta@gmail.com>

kyle-ssg and others added 30 commits October 21, 2025 11:26

Merge branch 'feat/segment-feature-state-view' into feat/segment-feat…

dcb6632

…ure-state-view-unified

Tests

6934c5f

Clean up types

72e8214

chore: componentise feature filters (#6119)

21697fe

Co-authored-by: Zaimwa9 <wadii.zaim@flagsmith.com>

Update contexts

ac641db

Update contexts

0c03b8f

Update contexts

fb2df65

Update contexts

b064e81

Update contexts

27019de

Update contexts

96c81d6

Update contexts

4a3bafa

Update contexts

4b846d9

Merge branch 'main' into chore/claude-context

6cbde85

Update contexts

dd7b743

Update frontend/web/components/feature-page/FeatureFilters.tsx

6a8f202

Co-authored-by: Zaimwa9 <wadii.zaim@flagsmith.com>

Update frontend/web/components/feature-page/FeatureFilters.tsx

ad8a35d

Co-authored-by: Zaimwa9 <wadii.zaim@flagsmith.com>

return early if key fields are null

659abf1

Merge branch 'main' into chore/componentise-feature-override-row

a00269e

Merge branch 'chore/componentise-feature-override-row' into feat/segm…

ae76a46

…ent-feature-state-view # Conflicts: # frontend/web/components/modals/AssociatedSegmentOverrides.js

Remove !

1b90569

Remove !

43e32ad

Merge branch 'chore/componentise-feature-override-row' into feat/segm…

7dcb60c

…ent-feature-state-view

Unused import

0ed455b

Fix sort order types

1381fb0

Re-add remove segment button

0ac5ded

Update claude contexts

df85873

Update claude contexts

a26b39a

Fix sortorder functionality

9ef5383

QA feedback

2ed1777

Fix permission check

f1c6066

kyle-ssg requested a review from a team as a code owner March 11, 2026 15:21

kyle-ssg requested review from talissoncosta and removed request for a team March 11, 2026 15:21

vercel bot deployed to Preview – flagsmith-frontend-preview March 11, 2026 15:22 View deployment

vercel bot deployed to Preview – flagsmith-frontend-staging March 11, 2026 15:22 View deployment

kyle-ssg changed the base branch from main to chore/permission-types March 11, 2026 15:22

github-actions bot added front-end Issue related to the React Front End Dashboard chore labels Mar 11, 2026

Comment

ba41b02

matthewelwell changed the title ~~chore: create feature migration~~ refactor: create feature migration Mar 11, 2026

github-actions bot added chore and removed chore labels Mar 11, 2026

vercel bot deployed to Preview – flagsmith-frontend-staging March 11, 2026 15:26 View deployment

vercel bot deployed to Preview – flagsmith-frontend-preview March 11, 2026 15:26 View deployment

talissoncosta reviewed Mar 11, 2026

View reviewed changes

frontend/web/components/modals/create-feature/tabs/IdentityOverridesTab.tsx Show resolved Hide resolved

talissoncosta requested changes Mar 12, 2026

View reviewed changes

Update frontend/web/components/modals/create-feature/tabs/IdentityOve…

c99dff2

…rridesTab.tsx Co-authored-by: Talisson <talisson.odcosta@gmail.com>

github-actions bot added refactor and removed chore labels Mar 18, 2026

vercel bot deployed to Preview – flagsmith-frontend-preview March 18, 2026 09:34 View deployment

vercel bot deployed to Preview – flagsmith-frontend-staging March 18, 2026 09:34 View deployment

talissoncosta force-pushed the chore/permission-types branch from fe307fc to d77370d Compare March 18, 2026 11:49

Base automatically changed from chore/permission-types to main March 18, 2026 16:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: create feature migration#6925

refactor: create feature migration#6925
kyle-ssg wants to merge 325 commits intomainfrom
chore/create-feature-migration-continued

kyle-ssg commented Mar 11, 2026 •

edited

Loading

Uh oh!

vercel bot commented Mar 11, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 11, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 11, 2026 •

edited

Loading

Uh oh!

talissoncosta Mar 11, 2026

Uh oh!

talissoncosta Mar 11, 2026

Uh oh!

talissoncosta Mar 11, 2026

Uh oh!

talissoncosta Mar 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

kyle-ssg commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

How did you test this code?

Uh oh!

vercel bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Docker builds report

Uh oh!

github-actions bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Uh oh!

talissoncosta Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

talissoncosta Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

talissoncosta Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

talissoncosta Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kyle-ssg commented Mar 11, 2026 •

edited

Loading

vercel bot commented Mar 11, 2026 •

edited

Loading

github-actions bot commented Mar 11, 2026 •

edited

Loading

github-actions bot commented Mar 11, 2026 •

edited

Loading