Skip to content

fix: add edit users sending up wrong data#6923

Merged
kyle-ssg merged 3 commits intomainfrom
fix/create-edit-group-members
Mar 18, 2026
Merged

fix: add edit users sending up wrong data#6923
kyle-ssg merged 3 commits intomainfrom
fix/create-edit-group-members

Conversation

@kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Mar 11, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

When adding a group member, the FE was sending up all existing group members. This caused an issue where MANAGE_USER_GROUPS did not have appropriate permissions to add themselves to a group.

Also, if a change errors the FE was silently swallowing them instead of showing them.

How did you test this code?

Added and removed members during edit / creation of a group

@kyle-ssg kyle-ssg requested a review from a team as a code owner March 11, 2026 10:57
@kyle-ssg kyle-ssg requested review from talissoncosta and removed request for a team March 11, 2026 10:57
@cursor
Copy link

cursor bot commented Mar 11, 2026

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on April 10.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@vercel
Copy link

vercel bot commented Mar 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Mar 18, 2026 11:01am
flagsmith-frontend-staging Ready Ready Preview, Comment Mar 18, 2026 11:01am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Mar 18, 2026 11:01am

Request Review

@kyle-ssg kyle-ssg changed the title Fix add edit users sending up wrong data fix: add edit users sending up wrong data Mar 11, 2026
@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Mar 11, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-6923 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-6923 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6923 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6923 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6923 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-6923 Finished ✅ Results

@github-actions
Copy link
Contributor

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  30.6 seconds
commit  53c1820
info  🔄 Run: #15235 (attempt 1)

@github-actions
Copy link
Contributor

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  54.1 seconds
commit  53c1820
info  🔄 Run: #15235 (attempt 1)

@github-actions
Copy link
Contributor

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  16 passed

Details

stats  16 tests across 13 suites
duration  57.3 seconds
commit  53c1820
info  🔄 Run: #15235 (attempt 1)

@github-actions
Copy link
Contributor

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  16 passed

Details

stats  16 tests across 13 suites
duration  28.5 seconds
commit  53c1820
info  🔄 Run: #15235 (attempt 1)

talissoncosta
talissoncosta previously approved these changes Mar 11, 2026
Copy link
Contributor

@talissoncosta talissoncosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kyle-ssg , thanks for handling this! I've left two inline comments, they're not blockers, but since the goal of this PR is to stop swallowing errors silently, it felt worth flagging for consistency.

@kyle-ssg
Copy link
Member Author

Hey @kyle-ssg , thanks for handling this! I've left two inline comments, they're not blockers, but since the goal of this PR is to stop swallowing errors silently, it felt worth flagging for consistency.

Done, I'd like to get this merged today if possible as it has been causing a real issue.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2026

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  47.5 seconds
commit  d252b3a
info  🔄 Run: #15334 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  28.8 seconds
commit  d252b3a
info  🔄 Run: #15334 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  58.3 seconds
commit  d252b3a
info  🔄 Run: #15334 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 3 seconds
commit  d252b3a
info  🔄 Run: #15334 (attempt 1)

Copy link
Contributor

@talissoncosta talissoncosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling that @kyle-ssg ! Good job!

@kyle-ssg kyle-ssg merged commit b249f2c into main Mar 18, 2026
27 checks passed
@kyle-ssg kyle-ssg deleted the fix/create-edit-group-members branch March 18, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants