feat: apply rules based on type instead of hardcoded all#297
Open
Zaimwa9 wants to merge 2 commits intorenovate/tests-engine_tests-engine-test-data-3.xfrom
Open
feat: apply rules based on type instead of hardcoded all#297Zaimwa9 wants to merge 2 commits intorenovate/tests-engine_tests-engine-test-data-3.xfrom
Zaimwa9 wants to merge 2 commits intorenovate/tests-engine_tests-engine-test-data-3.xfrom
Conversation
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 8cb614c |
khvn26
reviewed
May 4, 2026
khvn26
reviewed
May 4, 2026
khvn26
approved these changes
May 5, 2026
Member
khvn26
left a comment
khvn26
left a comment
There was a problem hiding this comment.
LGTM — glad to see no performance regressions here.
khvn26
changed the base branch from
main
to
renovate/tests-engine_tests-engine-test-data-3.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the rule's matching function (ALL/ANY/NONE) to sub-rules on top of conditions. Sub-rules were always evaluated with
all()independently of the rule's type, making it impossible to evaluate OR between groups of AND conditions.This unlocks
(environment_name=env_1 and some_trait=foo) or (environment_name=env_2 and some_trait=bar) or (environment_name=env_3 and some_trait=baz)without affecting existing segments and their behavior.