feat: add Oh My Pi (OMP) tool support

[xianzheTM]

Add ToolCommandAdapter for Oh My Pi terminal AI coding agent.

• New adapter: src/core/command-generation/adapters/oh-my-pi.ts
  • Commands: .omp/commands/opsx-.md with description frontmatter
  • Hyphen transform: /opsx: -> /opsx- (filename = command name)
  • Argument injection: Provided arguments: $@ after Input: heading
  • escapeYamlValue applied to description field
• Register in CommandAdapterRegistry and adapters/index.ts
• Add oh-my-pi to AI_TOOLS with skillsDir: '.omp'
• Add to hyphen command transformer whitelist in init.ts and update.ts
• Full test coverage (10 cases) in adapters.test.ts
• Update docs/supported-tools.md with directory reference and tool ID

Closes #713

Summary by CodeRabbit

• New Features
  • Added support for the Oh My Pi tool (oh-my-pi), including automatic detection when a .omp/ directory exists and generating command/skill files in the OMP folder structure.
• Bug Fixes
  • Enhanced command reference formatting for Oh My Pi and improved **Provided arguments**: $@ insertion after **Input**: with duplicate-avoidance.
• Documentation
  • Updated supported tool IDs plus CLI and command syntax docs to include Oh My Pi (/opsx-propose, /opsx-apply).
• Tests
  • Added adapter and available-tools coverage for Oh My Pi behavior.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Adds Oh My Pi (oh-my-pi) support across command generation, tool registration, init/update wiring, tests, and documentation. It generates .omp/commands/opsx-<id>.md command files, updates skill-command rewriting for Oh My Pi, and adds tool detection and docs entries.

Changes

Oh My Pi Tool Support

Layer / File(s)	Summary
Specs, design, and proposal documents openspec/changes/feat-add-omp-tool-support/*	New change-set documents describe OMP command and skill file generation, tool detection, task checklist items, and metadata for the change set.
ohMyPiAdapter implementation src/core/command-generation/adapters/oh-my-pi.ts, src/core/command-generation/adapters/index.ts	New adapter implementing getFilePath (.omp/commands/opsx-<id>.md) and formatFile (YAML frontmatter, transformToHyphenCommands, injectOmpArgs); re-exported from the adapter index.
Registry, config, init/update wiring, tests, and docs src/core/command-generation/registry.ts, src/core/config.ts, src/core/init.ts, src/core/update.ts, test/core/command-generation/adapters.test.ts, test/core/available-tools.test.ts, docs/cli.md, docs/commands.md, docs/how-commands-work.md, docs/supported-tools.md	Registers ohMyPiAdapter, adds oh-my-pi to AI_TOOLS, broadens hyphen-command transformation in init/update, adds adapter and tool-detection coverage, and updates command/tool documentation.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

• Fission-AI/OpenSpec#556: Adds related command-generation adapter infrastructure that this PR extends with a new tool adapter.
• Fission-AI/OpenSpec#626: Introduced transformToHyphenCommands and related init/update wiring that this PR expands for oh-my-pi.
• Fission-AI/OpenSpec#950: Added $@ injection and hyphen-command transformation behavior for another tool adapter, which this PR applies to oh-my-pi.

Suggested reviewers: alfred-openspec, TabishB

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is concise and accurately summarizes the main change: adding Oh My Pi tool support.
Linked Issues check	✅ Passed	The PR implements the requested oh-my-pi agent toolkit support with adapter, config, registry, docs, and tests.
Out of Scope Changes check	✅ Passed	The documented code and doc changes stay focused on Oh My Pi support and related tool lists, with no clear unrelated scope.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (2)

test/core/command-generation/adapters.test.ts (1)

22-22: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Import is out of alphabetical order.

ohMyPiAdapter should be imported before opencodeAdapter to maintain alphabetical ordering (oh < op). Move this import to between kilocodeAdapter (line 20) and opencodeAdapter (line 21).

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@test/core/command-generation/adapters.test.ts` at line 22, The import order
in the adapter test setup is not alphabetical. Reorder the imports in
adapters.test.ts so that ohMyPiAdapter is placed before opencodeAdapter, keeping
it between kilocodeAdapter and opencodeAdapter and preserving the existing
alphabetical sequence among the adapter imports.

openspec/changes/feat-add-omp-tool-support/specs/oh-my-pi-tool/spec.md (1)

6-6: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Redundant phrasing: "follows after"

"follows after" is redundant; use "follows" or "comes after". Also, this sentence is very long and hard to parse. Consider breaking it into shorter sentences for clarity.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@openspec/changes/feat-add-omp-tool-support/specs/oh-my-pi-tool/spec.md` at
line 6, The spec wording in the command-body requirements is too verbose and
includes redundant phrasing; update the text in the Oh My Pi tool spec to use
simpler language, replacing “follows after” with “follows” or “comes after” and
splitting the long sentence into shorter, clearer sentences. Keep the same
requirements in the spec entry that mentions the YAML frontmatter, `/opsx:` to
`/opsx-` transformation, and `**Provided arguments**: $@` injection, but rewrite
that description for readability.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@openspec/changes/feat-add-omp-tool-support/specs/oh-my-pi-tool/spec.md`:
- Line 6: The spec wording in the command-body requirements is too verbose and
includes redundant phrasing; update the text in the Oh My Pi tool spec to use
simpler language, replacing “follows after” with “follows” or “comes after” and
splitting the long sentence into shorter, clearer sentences. Keep the same
requirements in the spec entry that mentions the YAML frontmatter, `/opsx:` to
`/opsx-` transformation, and `**Provided arguments**: $@` injection, but rewrite
that description for readability.

In `@test/core/command-generation/adapters.test.ts`:
- Line 22: The import order in the adapter test setup is not alphabetical.
Reorder the imports in adapters.test.ts so that ohMyPiAdapter is placed before
opencodeAdapter, keeping it between kilocodeAdapter and opencodeAdapter and
preserving the existing alphabetical sequence among the adapter imports.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 859e2f0a-1a3f-42c2-ae7b-90b3407f037c

📥 Commits

Reviewing files that changed from the base of the PR and between 546224e and 2f97ab8.

📒 Files selected for processing (15)

• docs/supported-tools.md
• openspec/changes/feat-add-omp-tool-support/.openspec.yaml
• openspec/changes/feat-add-omp-tool-support/design.md
• openspec/changes/feat-add-omp-tool-support/proposal.md
• openspec/changes/feat-add-omp-tool-support/specs/cli-init/spec.md
• openspec/changes/feat-add-omp-tool-support/specs/cli-update/spec.md
• openspec/changes/feat-add-omp-tool-support/specs/oh-my-pi-tool/spec.md
• openspec/changes/feat-add-omp-tool-support/tasks.md
• src/core/command-generation/adapters/index.ts
• src/core/command-generation/adapters/oh-my-pi.ts
• src/core/command-generation/registry.ts
• src/core/config.ts
• src/core/init.ts
• src/core/update.ts
• test/core/command-generation/adapters.test.ts

[alfred-openspec]

Looks good. I verified the OMP docs match the core assumptions: project commands live under .omp/commands/*.md, filename stem becomes the slash command, YAML description is valid, and $@ / $ARGUMENTS are supported for arguments.

The adapter follows the existing command-generation pattern, registers cleanly, applies hyphen command references in init/update/legacy upgrade, and has focused tests for path, YAML escaping, reference transform, and argument injection.

Verified locally: pnpm exec vitest run test/core/command-generation/adapters.test.ts passes, 103 tests.

[xianzheTM]

@TabishB Hi maintainers, this PR has passed automated checks. Could someone take a look when you have a chance? I'm happy to make any changes if needed. Thanks for your time!

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/commands.md`:
- Around line 326-328: Add a language tag to both fenced examples in the
commands documentation so markdownlint MD040 passes. Update the unlabeled code
fences around the /opsx:update examples in the affected section, using a tag
like text, and make the same change in the additional /opsx:update example block
referenced by the review comment.
- Around line 331-334: The markdown table in the commands documentation is
directly adjacent to surrounding text, triggering MD058. Add a blank line before
and after the table near the change-name argument section so the table is
properly separated from the preceding and following content.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 31daae3f-7e8d-4401-9ed6-5c8e914fc11b

📥 Commits

Reviewing files that changed from the base of the PR and between 6931d26 and 84d014d.

📒 Files selected for processing (5)

• docs/cli.md
• docs/commands.md
• docs/supported-tools.md
• src/core/init.ts
• test/core/command-generation/adapters.test.ts

✅ Files skipped from review due to trivial changes (2)

• docs/supported-tools.md
• docs/cli.md

🚧 Files skipped from review as they are similar to previous changes (2)

• test/core/command-generation/adapters.test.ts
• src/core/init.ts

[coderabbitai]

Caution

Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/commands.md`:
- Around line 326-328: Add a language tag to both fenced examples in the
commands documentation so markdownlint MD040 passes. Update the unlabeled code
fences around the /opsx:update examples in the affected section, using a tag
like text, and make the same change in the additional /opsx:update example block
referenced by the review comment.
- Around line 331-334: The markdown table in the commands documentation is
directly adjacent to surrounding text, triggering MD058. Add a blank line before
and after the table near the change-name argument section so the table is
properly separated from the preceding and following content.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 31daae3f-7e8d-4401-9ed6-5c8e914fc11b

📥 Commits

Reviewing files that changed from the base of the PR and between 6931d26 and 84d014d.

📒 Files selected for processing (5)

• docs/cli.md
• docs/commands.md
• docs/supported-tools.md
• src/core/init.ts
• test/core/command-generation/adapters.test.ts

✅ Files skipped from review due to trivial changes (2)

• docs/supported-tools.md
• docs/cli.md

🚧 Files skipped from review as they are similar to previous changes (2)

• test/core/command-generation/adapters.test.ts
• src/core/init.ts

🛑 Comments failed to post (2)

docs/commands.md (2)

326-328: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Add language tags to both fenced examples.

Both code fences are unlabeled, which trips MD040. Use a language tag such as text so the doc passes markdownlint.

Proposed fix

-```
+```text
 /opsx:update [change-name]

```diff
-```
+```text
 You: /opsx:update add-dark-mode - we're storing the theme in a cookie now, not localStorage
@@

</details>


Also applies to: 343-356

<details>
<summary>🧰 Tools</summary>

<details>
<summary>🪛 markdownlint-cli2 (0.22.1)</summary>

[warning] 326-326: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

</details>

</details>

<details>
<summary>🤖 Prompt for AI Agents</summary>

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @docs/commands.md around lines 326 - 328, Add a language tag to both fenced
examples in the commands documentation so markdownlint MD040 passes. Update the
unlabeled code fences around the /opsx:update examples in the affected section,
using a tag like text, and make the same change in the additional /opsx:update
example block referenced by the review comment.

</details>

<!-- fingerprinting:phantom:triton:quartz -->

<!-- cr-indicator-types:potential_issue -->

<!-- cr-comment:v1:00d86fabc33879666cd1e199 -->

_Source: Linters/SAST tools_

<!-- This is an auto-generated comment by CodeRabbit -->

---

331-334: _📐 Maintainability & Code Quality_ | _🟡 Minor_ | _⚡ Quick win_

**Separate the table from surrounding text.**

This table is not surrounded by blank lines, which triggers MD058. Add one blank line before and after it.    

<details>
<summary>Proposed fix</summary>

```diff
 **Arguments:**
+
 | Argument | Required | Description |
 |----------|----------|-------------|
 | `change-name` | No | Which change to update (inferred from context if not provided) |
+
 **What it does:**

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

**Arguments:**

| Argument | Required | Description |
|----------|----------|-------------|
| `change-name` | No | Which change to update (inferred from context if not provided) |

**What it does:**

🧰 Tools

🪛 markdownlint-cli2 (0.22.1)

[warning] 331-331: Tables should be surrounded by blank lines

(MD058, blanks-around-tables)

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/commands.md` around lines 331 - 334, The markdown table in the commands
documentation is directly adjacent to surrounding text, triggering MD058. Add a
blank line before and after the table near the change-name argument section so
the table is properly separated from the preceding and following content.

Source: Linters/SAST tools