Skip to content

Implement #8928 : Add limit for max value of -PARALLEL switch value when restoring a database #8954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hvlad merged 1 commit into from
Mar 25, 2026
+7 −1
Merged

Implement #8928 : Add limit for max value of -PARALLEL switch value when restoring a database #8954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion doc/README.gbak
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,12 @@ this case engine will use value of ParallelWorkers setting when building
indices, i.e. this phase could be run in parallel by the engine itself. To
fully avoid parallel operations when restoring database, use -PARALLEL 1.

Note, gbak not uses firebird.conf by itself and ParallelWorkers setting does
Note: gbak not uses firebird.conf by itself and ParallelWorkers setting does
not affect its operations.

Note: the upper limit for the number of parallel workers is 64 and applied by
both backup and restore.


Examples.

Expand Down
2 changes: 2 additions & 0 deletions src/burp/burp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -899,6 +899,8 @@ int gbak(Firebird::UtilSvc* uSvc)
BURP_error(408, true, argv[itr]);
// msg 408 expected parallel workers, encountered "%s"
}
if (tdgbl->gbl_sw_par_workers > BURP_MAX_PARALLEL_WORKERS)
tdgbl->gbl_sw_par_workers = BURP_MAX_PARALLEL_WORKERS;
break;
case IN_SW_BURP_Y:
{
Expand Down
1 change: 1 addition & 0 deletions src/burp/burpswi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,7 @@ static const char* burp_repl_mode_sw_table[] =
BURP_SW_MODE_NONE, BURP_SW_MODE_RO, BURP_SW_MODE_RW
};

const int BURP_MAX_PARALLEL_WORKERS = 64;
Copy link
Copy Markdown
Contributor

@aafemt aafemt Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

constexpr may be?..

Copy link
Copy Markdown
Member Author

@hvlad hvlad Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no reason to use 1 constexpr while other 55 are const int.
And - no - I'm not going to replace all other const int in this PR.


#endif // BURP_BURP_H

Loading