Skip to content

feature: add fastforward hello message latency metric#33

Merged
Federico2014 merged 1 commit into
Federico2014:pqc-falcon512from
Little-Peony:pqc-falcon512
May 26, 2026
Merged

feature: add fastforward hello message latency metric#33
Federico2014 merged 1 commit into
Federico2014:pqc-falcon512from
Little-Peony:pqc-falcon512

Conversation

@Sunny6889
Copy link
Copy Markdown

@Sunny6889 Sunny6889 commented May 26, 2026

What does this PR do?

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details


Summary by cubic

Adds a Prometheus histogram to measure handshake round‑trip latency on the SR<->FF path, from TCP connect to HelloMessage processed. This improves visibility into FastForward handshake performance.

  • New Features
    • Introduced tron:handshake_latency_seconds and initialized it in MetricsHistogram.
    • Metric is recorded only for SR<->FF handshakes: inbound signed HelloMessage (witness or pqAuthSig) or peers listed in node.fastForward.nodes (via RelayService.isFastForwardPeer).

Written for commit ea3dc85. Summary will update on new commits. Review in cubic

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 26, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ce31d6ec-cd39-4365-bb5e-13ef4cc61a79

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Re-trigger cubic

@Federico2014 Federico2014 merged commit 4c5720d into Federico2014:pqc-falcon512 May 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants