Add test for issue #315 using GeneratorInitializer to write custom XML declaration encoding#842
Closed
Add test for issue #315 using GeneratorInitializer to write custom XML declaration encoding#842
Conversation
Copilot
AI
changed the title
[WIP] Add test for generator initializer in issue #315
Add test for issue #315 using GeneratorInitializer to write custom XML declaration encoding
Apr 1, 2026
Member
|
added a test with ae7e650 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #315 reports that the XML declaration encoding is hard-coded to
UTF-8, with no supported mechanism to emit a different encoding (e.g.ISO-8859-1). TheGeneratorInitializerextension point added in jackson-databind 3.2 (databind#5860) provides a clean solution: the initializer receives the freshly-createdToXmlGeneratorbefore any content is written, allowing direct access to the underlyingXMLStreamWriterto write a custom<?xml?>declaration.Changes
GeneratorInitializer315Testinsrc/test/java/…/xml/ser/demonstrating the workaround:GeneratorInitializerviaXmlMapper.builder().generatorInitializer(...)JsonGenerator→ToXmlGenerator, retrievesXMLStreamWriterviagetStaxWriter()sw.writeStartDocument("ISO-8859-1", "1.0")before Jackson writes any contentWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
central.sonatype.com/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.14/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.14/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.14 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.14/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/jackson-dataformat-xml/jackson-dataformat-xml org.codehaus.plexus.classworlds.launcher.Launcher dependency:resolve -q(dns block)/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.14/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.14/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.14 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.14/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/jackson-dataformat-xml/jackson-dataformat-xml org.codehaus.plexus.classworlds.launcher.Launcher help:effective-pom -q(dns block)/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.14/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.14/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.14 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.14/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/jackson-dataformat-xml/jackson-dataformat-xml org.codehaus.plexus.classworlds.launcher.Launcher dependency:list -q(dns block)If you need me to access, download, or install something from one of these locations, you can either: