Revise agent rules titles and subtitles#93751
Open
jamesdeanexpensify wants to merge 4 commits into
Open
Conversation
Updated titles and descriptions for agent rules to improve clarity.
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. |
This comment has been minimized.
This comment has been minimized.
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index f7add8462ae..e021922f483 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -7402,15 +7402,15 @@ Fügen Sie weitere Ausgabelimits hinzu, um den Cashflow Ihres Unternehmens zu sc
`${action === CONST.SPEND_RULES.ACTION.BLOCK ? 'Blockiert' : 'Erlaubt'} ${shownCount > 1 ? 'Kategorien' : 'Kategorie'}: ${categories}${hiddenCount > 0 ? `, +${hiddenCount} weitere` : ''}`,
},
agentRules: {
- title: 'Agent-Regeln',
- subtitle: 'Beschreiben Sie flexible Regeln, die ausgeführt werden, wenn Sie sie benötigen.',
- addRule: 'Agent-Regel hinzufügen',
- findRule: 'Agent-Regel finden',
+ title: 'Agentenregeln',
+ subtitle: 'Legen Sie Regeln fest, wie KI-Agenten mit Ausgaben in diesem Workspace umgehen.',
+ addRule: 'Agentenregel hinzufügen',
+ findRule: 'Agentenregel finden',
addRuleTitle: 'Regel hinzufügen',
editRuleTitle: 'Regel bearbeiten',
deleteRule: 'Regel löschen',
deleteRuleConfirmation: 'Sind Sie sicher, dass Sie diese Regel löschen möchten?',
- describeRuleTitle: 'Beschreiben Sie Ihre Regel und Concierge erstellt sie',
+ describeRuleTitle: 'Beschreiben Sie die Regel, der Ihre KI-Agentin/Ihr KI-Agent folgen soll',
disclaimer: 'KI-Agenten können Fehler machen.',
agentCreatedTitle: 'RuleBot wurde zu Ihrem Arbeitsbereich hinzugefügt!',
agentCreatedDescription: (agentsRoute: string) =>
diff --git a/src/languages/es.ts b/src/languages/es.ts
index aca9a35e896..cef55552c87 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -1753,7 +1753,6 @@ const translations: TranslationDeepObject<typeof en> = {
}
},
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_MARK_AS_DONE]: (actor, actorType, _eta, _etaType) => {
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando a que <strong>tú</strong> lo marques como listo.`;
@@ -7295,12 +7294,12 @@ ${amount} para ${merchant} - ${date}`,
},
},
agentRules: {
- title: 'Reglas de Agente',
- subtitle: 'Describe reglas flexibles que se ejecutan cuando las necesitas.',
- addRule: 'Añadir regla de Agente',
- findRule: 'Buscar regla de Agente',
+ title: 'Reglas del agente',
+ subtitle: 'Configura reglas para cómo los agentes de IA gestionan los gastos en este espacio de trabajo.',
+ addRule: 'Añadir regla de agente',
+ findRule: 'Encontrar regla de agente',
addRuleTitle: 'Añadir regla',
- describeRuleTitle: 'Describe tu regla y Concierge la creará',
+ describeRuleTitle: 'Describe la regla que debe seguir tu agente de IA',
editRuleTitle: 'Editar regla',
deleteRule: 'Eliminar regla',
deleteRuleConfirmation: '¿Seguro que quieres eliminar esta regla?',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 9a8c3cdb364..cf9eef1ea38 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -1,6 +1,7 @@
/**
* _____ __ __
* / ___/__ ___ ___ _______ _/ /____ ___/ /
+ * / (_ / -_) _ \/ -_) __/ _ \`/ __/ -_) _ /
* \___/\__/_//_/\__/_/ \_,_/\__/\__/\_,_/
*
* This file was automatically generated. Please consider these alternatives before manually editing it:
@@ -862,7 +863,7 @@ const translations: TranslationDeepObject<typeof en> = {
beginningOfChatHistory: (users: string) => `Cette discussion est avec ${users}.`,
beginningOfChatHistoryPolicyExpenseChat: (workspaceName: string, submitterDisplayName: string) =>
`C’est ici que <strong>${submitterDisplayName}</strong> soumettra des dépenses à <strong>${workspaceName}</strong>. Utilisez simplement le bouton +.`,
- beginningOfChatHistoryPolicyExpenseChatTrack: 'C\u2019est ici que vous suivrez vos dépenses',
+ beginningOfChatHistoryPolicyExpenseChatTrack: 'C’est ici que vous suivrez vos dépenses',
beginningOfChatHistorySelfDM: 'Ceci est votre espace personnel. Utilisez-le pour vos notes, tâches, brouillons et rappels.',
beginningOfChatHistorySystemDM: 'Bienvenue ! Procédons à la configuration.',
chatWithAccountManager: 'Discutez avec votre gestionnaire de compte ici',
@@ -7428,15 +7429,15 @@ Ajoutez davantage de règles de dépenses pour protéger la trésorerie de l’e
`${action === CONST.SPEND_RULES.ACTION.BLOCK ? 'Bloqué' : 'Autorisé'} ${shownCount > 1 ? 'catégories' : 'catégorie'}: ${categories}${hiddenCount > 0 ? `, +${hiddenCount} de plus` : ''}`,
},
agentRules: {
- title: 'Règles Agent',
- subtitle: 'Décrivez des règles flexibles qui s’exécutent quand vous en avez besoin.',
- addRule: 'Ajouter une règle Agent',
- findRule: 'Rechercher une règle Agent',
+ title: 'Règles d’agent',
+ subtitle: 'Définissez des règles pour déterminer comment les agents IA gèrent les dépenses dans cet espace de travail.',
+ addRule: 'Ajouter une règle d’agent',
+ findRule: 'Rechercher une règle d’agent',
addRuleTitle: 'Ajouter une règle',
editRuleTitle: 'Modifier la règle',
deleteRule: 'Supprimer la règle',
deleteRuleConfirmation: 'Voulez-vous vraiment supprimer cette règle ?',
- describeRuleTitle: 'Décrivez votre règle et Concierge la créera',
+ describeRuleTitle: 'Décrivez la règle que votre agent IA doit suivre',
disclaimer: 'Les agents IA peuvent faire des erreurs.',
agentCreatedTitle: 'RuleBot a été ajouté à votre espace de travail !',
agentCreatedDescription: (agentsRoute: string) =>
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 1eb5973eb41..ffb16906b2d 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -7386,15 +7386,15 @@ Aggiungi altre regole di spesa per proteggere il flusso di cassa aziendale.`,
`${action === CONST.SPEND_RULES.ACTION.BLOCK ? 'Bloccato' : 'Consentito'} ${shownCount > 1 ? 'categorie' : 'categoria'}: ${categories}${hiddenCount > 0 ? `, +${hiddenCount} in più` : ''}`,
},
agentRules: {
- title: 'Regole Agente',
- subtitle: 'Descrivi regole flessibili che vengono eseguite quando ne hai bisogno.',
- addRule: 'Aggiungi regola Agente',
- findRule: 'Trova regola Agente',
+ title: 'Regole agente',
+ subtitle: 'Imposta le regole su come gli agenti IA gestiscono le spese in questo spazio di lavoro.',
+ addRule: 'Aggiungi regola agente',
+ findRule: 'Trova regola agente',
addRuleTitle: 'Aggiungi regola',
editRuleTitle: 'Modifica regola',
deleteRule: 'Elimina regola',
deleteRuleConfirmation: 'Sei sicuro di voler eliminare questa regola?',
- describeRuleTitle: 'Descrivi la tua regola e Concierge la creerà',
+ describeRuleTitle: 'Descrivi la regola che il tuo agente AI deve seguire',
disclaimer: 'Gli agenti IA possono commettere errori.',
agentCreatedTitle: 'RuleBot è stato aggiunto al tuo spazio di lavoro!',
agentCreatedDescription: (agentsRoute: string) =>
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 52bf0fc70a1..7053bb5af97 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -7304,15 +7304,15 @@ ${reportName}
`${action === CONST.SPEND_RULES.ACTION.BLOCK ? 'ブロック済み' : '許可されています'} ${shownCount > 1 ? 'カテゴリ' : 'カテゴリ'}: ${categories}${hiddenCount > 0 ? `、ほか +${hiddenCount} 件` : ''}`,
},
agentRules: {
- title: 'エージェント ルール',
- subtitle: '必要なときに実行される柔軟なルールを記述します。',
- addRule: 'エージェント ルールを追加',
- findRule: 'エージェント ルールを検索',
+ title: 'エージェントルール',
+ subtitle: 'このワークスペースで AI エージェントが経費を処理する方法のルールを設定します。',
+ addRule: 'エージェントルールを追加',
+ findRule: 'エージェントルールを検索',
addRuleTitle: 'ルールを追加',
editRuleTitle: 'ルールを編集',
deleteRule: 'ルールを削除',
deleteRuleConfirmation: 'このルールを削除してもよろしいですか？',
- describeRuleTitle: 'ルールの内容を入力すると、Concierge が自動作成します',
+ describeRuleTitle: 'AI エージェントに従わせるルールを記述してください',
disclaimer: 'AI エージェントは間違える場合があります。',
agentCreatedTitle: 'RuleBot がワークスペースに追加されました!',
agentCreatedDescription: (agentsRoute: string) =>
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 6a6c34e4e18..bfce343bca2 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -7362,14 +7362,14 @@ er bestedingsregels toe om de kasstroom van het bedrijf te beschermen.`,
},
agentRules: {
title: 'Agentregels',
- subtitle: 'Beschrijf flexibele regels die worden uitgevoerd wanneer je ze nodig hebt.',
+ subtitle: 'Stel regels in voor hoe AI-agenten met uitgaven omgaan in deze werkruimte.',
addRule: 'Agentregel toevoegen',
findRule: 'Agentregel zoeken',
addRuleTitle: 'Regel toevoegen',
editRuleTitle: 'Regel bewerken',
deleteRule: 'Regel verwijderen',
deleteRuleConfirmation: 'Weet je zeker dat je deze regel wilt verwijderen?',
- describeRuleTitle: 'Beschrijf je regel en Concierge maakt hem voor je',
+ describeRuleTitle: 'Beschrijf de regel die je AI-agent moet volgen',
disclaimer: 'AI-agents kunnen fouten maken.',
agentCreatedTitle: 'RuleBot is toegevoegd aan je werkruimte!',
agentCreatedDescription: (agentsRoute: string) =>
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 20c204fbe68..1f569e84878 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -7354,15 +7354,15 @@ Dodaj więcej zasad wydatków, żeby chronić płynność finansową firmy.`,
`${action === CONST.SPEND_RULES.ACTION.BLOCK ? 'Zablokowane' : 'Dozwolone'} ${shownCount > 1 ? 'kategorie' : 'kategoria'}: ${categories}${hiddenCount > 0 ? `, +${hiddenCount} więcej` : ''}`,
},
agentRules: {
- title: 'Zasady Agenta',
- subtitle: 'Opisz elastyczne reguły, które działają wtedy, gdy ich potrzebujesz.',
- addRule: 'Dodaj regułę Agenta',
- findRule: 'Znajdź regułę Agenta',
+ title: 'Zasady agenta',
+ subtitle: 'Ustaw zasady dotyczące tego, jak agenci AI obsługują wydatki w tym obszarze roboczym.',
+ addRule: 'Dodaj regułę agenta',
+ findRule: 'Znajdź regułę agenta',
addRuleTitle: 'Dodaj regułę',
editRuleTitle: 'Edytuj regułę',
deleteRule: 'Usuń regułę',
deleteRuleConfirmation: 'Na pewno chcesz usunąć tę regułę?',
- describeRuleTitle: 'Opisz swoją regułę, a Concierge ją utworzy',
+ describeRuleTitle: 'Opisz zasadę, której ma przestrzegać twój agent AI',
disclaimer: 'Agenci AI mogą popełniać błędy.',
agentCreatedTitle: 'RuleBot został dodany do Twojego obszaru roboczego!',
agentCreatedDescription: (agentsRoute: string) =>
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 5ed67da5377..8f7ea352f7f 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -7360,15 +7360,15 @@ Adicione mais regras de gasto para proteger o fluxo de caixa da empresa.`,
`${action === CONST.SPEND_RULES.ACTION.BLOCK ? 'Bloqueado' : 'Permitido'} ${shownCount > 1 ? 'categorias' : 'categoria'}: ${categories}${hiddenCount > 0 ? `, +${hiddenCount} mais` : ''}`,
},
agentRules: {
- title: 'Regras de Agente',
- subtitle: 'Descreva regras flexíveis que rodam quando você precisa.',
- addRule: 'Adicionar regra de Agente',
- findRule: 'Encontrar regra de Agente',
+ title: 'Regras do agente',
+ subtitle: 'Defina regras para como os agentes de IA lidam com despesas neste workspace.',
+ addRule: 'Adicionar regra de agente',
+ findRule: 'Encontrar regra de agente',
addRuleTitle: 'Adicionar regra',
editRuleTitle: 'Editar regra',
deleteRule: 'Excluir regra',
deleteRuleConfirmation: 'Tem certeza de que quer excluir esta regra?',
- describeRuleTitle: 'Descreva sua regra e a Concierge vai criá-la',
+ describeRuleTitle: 'Descreva a regra que seu agente de IA deve seguir',
disclaimer: 'Os agentes de IA podem cometer erros.',
agentCreatedTitle: 'O RuleBot foi adicionado ao seu espaço de trabalho!',
agentCreatedDescription: (agentsRoute: string) =>
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 09d8080b40a..9850584eed0 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -7173,14 +7173,14 @@ ${reportName}
},
agentRules: {
title: '代理规则',
- subtitle: '描述在你需要时运行的灵活规则。',
+ subtitle: '为此工作区设置 AI 代理处理报销的规则。',
addRule: '添加代理规则',
findRule: '查找代理规则',
addRuleTitle: '添加规则',
editRuleTitle: '编辑规则',
deleteRule: '删除规则',
deleteRuleConfirmation: '确定要删除此规则吗？',
- describeRuleTitle: '描述你的规则，我们会由 Concierge 为你创建',
+ describeRuleTitle: '描述你的 AI 代理需要遵循的规则',
disclaimer: 'AI 智能体可能会犯错。',
agentCreatedTitle: 'RuleBot 已添加到你的工作区!',
agentCreatedDescription: (agentsRoute: string) =>
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Contributor
Author
|
@MelvinBot do you know if the Polyglot Parrot translations reflect my latest commit? |
Contributor
|
Yes — the most recent 🦜 Polyglot Parrot comment (posted 22:13:13Z) reflects your latest commit The Parrot comment is generated by the Translation Dry Run workflow, which re-runs on every push. The latest run was triggered on Commit ↔ Parrot comment mapping
|
Contributor
Author
|
@MelvinBot implement the Polyglot Parrot translations |
Contributor
|
I can apply the latest 🦜 Polyglot Parrot translation diff (the one from the comment posted 22:13:13Z, generated on your latest commit
Once I'm added as an assignee, reply with |
Contributor
Author
|
@MelvinBot implement the Polyglot Parrot translations |
Contributor
|
Happy to apply the latest 🦜 Polyglot Parrot translation diff (from the comment generated on your latest commit |
Contributor
Author
|
@MelvinBot implement the Polyglot Parrot translations |
Contributor
|
I can apply the latest 🦜 Polyglot Parrot translation diff (from commit What I'd do once unblocked
|
Contributor
Author
|
@MelvinBot implement the Polyglot Parrot translations |
Apply the auto-generated translations from Polyglot Parrot reflecting the latest agent rules title/subtitle/description copy updates. Co-authored-by: James Dean <jamesdeanexpensify@users.noreply.github.com>
Contributor
|
Done — applied the latest 🦜 Polyglot Parrot translation diff (from the 22:13:13Z comment, generated against What changed: the Checks run locally
The new commit will kick off a fresh Translation Dry Run; since the translations now match the English source, the next Parrot comment should show an empty diff. |
melvin-bot
Bot
requested review from
JmillsExpensify and
cristipaval
and removed request for
a team
|
@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated titles and descriptions for agent rules to improve clarity.
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
Rulesis enabled (More features > Rules)Agent Rulesand make sure the copy is updatedPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari