fix: surface missing EVERMEM_API_KEY at SessionStart instead of failing silently#16
Open
sunnyadn wants to merge 1 commit into
Open
fix: surface missing EVERMEM_API_KEY at SessionStart instead of failing silently#16sunnyadn wants to merge 1 commit into
sunnyadn wants to merge 1 commit into
Conversation
…iling silently When the key isn't configured, all hooks no-op silently and the user gets no signal that memory is disabled. Surface it once per session at SessionStart (non-blocking). Configured sessions are unchanged.
sunnyadn
force-pushed
the
fix/surface-missing-api-key
branch
from
a94eaad to
96daa99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15.
Surface a missing
EVERMEM_API_KEYonce per session instead of failing silently.Problem — when the key isn't configured, every hook hits its
isConfigured()guard and exits with no output, so the user gets no signal that memory is disabled and assumes it works.Change —
SessionStartruns once per session, so turn the silent!config.isConfiguredskip insession-context.jsinto a one-time, non-blocking (continue: true) warning, reusing the file's existingsystemMessagepattern (same as the Node-version checks above it). Configured sessions are unchanged.Test —
SessionStartwith the key unset emits the warning; with the key set, output is unchanged.