GH-1338 Disable movement check for teleports#1338
Open
Conversation
…nt during teleportation
CitralFlo
requested review from
ChudziudgiToJa,
Jakubk15,
igoyek,
imDMK and
vLuckyyy
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a configuration setting to toggle whether player movement cancels a teleportation task. The changes include the addition of TeleportConfig and TeleportSettings, and the integration of these settings into TeleportTask. A suggestion was provided to optimize the movement check in TeleportTask by reordering the conditional logic to leverage short-circuit evaluation.
…leport/TeleportTask.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
CitralFlo
changed the title
Jakubk15
reviewed
Apr 19, 2026
Jakubk15
reviewed
Apr 19, 2026
Jakubk15
approved these changes
Apr 21, 2026
imDMK
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Disable movement check for teleports.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: