refactor: rename dataset to suite across codebase#944
Merged
Conversation
An eval file is a test suite (lifecycle hooks, workspace setup/teardown, execution config), not a dataset (passive input/output pairs). This renames the `dataset` field to `suite` everywhere: - Core types: EvalTest.suite, EvaluationResult.suite - Wire format: JSONL results write `suite` field - CLI: --group-by suite, --suite flag, trace/trend/pipeline commands - Studio UI: routes /suite/, labels "Suites", API endpoints /suites - OTel: agentv.suite attribute - Example baseline JSONL files updated - Documentation and plugin skill files updated Hard deprecation — no backward-compat aliases for `dataset`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The tests used hardcoded Windows backslash paths which fail on Linux. Use path.join and path.sep for cross-platform compatibility. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Explains the suite concept as requested in #943 comment. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Deploying agentv with
|
| Latest commit: |
649edf6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0cc6458a.agentv.pages.dev |
| Branch Preview URL: | https://refactor-943-dataset-to-suit.agentv.pages.dev |
- Fix missed verbose log "JSONL Dataset:" → "JSONL Suite:" in jsonl-parser - Clean up stale "legacy" comment in discover.ts - Rename internal datasetFile/datasetFilePath vars in check-eval-baselines script Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dataset→suitein core types (EvalTest.suite,EvaluationResult.suite), wire format (JSONLsuitefield), CLI flags (--group-by suite,--suite), Studio UI (routes/suite/, labels "Suites", API/suites), OTel attributes, example baselines, docs, and plugin skill filesdatasetpi-coding-agenttests103 files changed across
packages/core/,apps/cli/,apps/studio/,apps/web/,examples/, andplugins/.Closes #943
Test plan
bun run build— passesbun run typecheck— passes (core)bun run lint— passesbun run test— 1745 tests pass (1363 core + 382 CLI), 0 failbun run validate:examples— 53/53 valid🤖 Generated with Claude Code