fix(core): hard-deprecate runner batch config#1740
Merged
Conversation
Deploying agentv with
|
| Latest commit: |
e6ed4b0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e2ec417a.agentv.pages.dev |
| Branch Preview URL: | https://av-di3a-hard-deprecate-batch.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Runner-level eval batching is now hard-deprecated instead of silently falling back to per-case dispatch. Provider config rejects
batch_requests,provider_batching, andproviderBatchingwith guidance to keep queueing or batching inside provider adapters behind normal per-requestinvokecalls.The eval orchestrator no longer has a
runBatchEvaluationbranch, and the coreProviderinterface no longer exposes runner-selectedsupportsBatch/invokeBatchcapability hooks. Existing concrete providerinvokeBatchhelper methods remain only as internal/direct helper behavior for surfaces such as script-grader provider clients; they are not reachable from eval-runner dispatch.Related: av-di3a
Validation
bun test packages/core/test/evaluation/providers/targets.test.ts packages/core/test/evaluation/validation/targets-validator.test.ts packages/core/test/evaluation/orchestrator.test.ts packages/core/test/evaluation/providers/pi-coding-agent.test.tsbun test apps/cli/test/commands/eval/task-bundle.test.tsbun --filter @agentv/core buildbun --filter @agentv/core typecheckbun --filter @agentv/sdk buildbun --filter agentv typecheckbun --filter agentv buildbunx biome check <touched files>git diff --checkbun test packages/core/test/evaluation/loaders/config-loader.test.ts packages/core/test/evaluation/config.test.tsagentvCLI build exited 0. It printed existing bundler warnings from Zod declaration imports and skipped Dashboard static copy becauseapps/dashboard/distwas absent.Code review: skipped because the available subagent tool policy forbids spawning unless the user explicitly asked for delegation; performed a manual diff scan instead.
Evidence
Live dogfood passed with a real PI coding-agent candidate and Azure LLM grader:
bun apps/cli/src/cli.ts eval run \ .agentv/results/av-di3a-dogfood/inputs/per-case.eval.yaml \ --providers .agentv/results/av-di3a-dogfood/inputs/providers.yaml \ --provider pi-sdk-azure \ --grader-provider azure-grader \ --workers 1 \ --output .agentv/results/av-di3a-dogfood/run-azureThe run used
evaluate_options.repeat: 2and produced the expected aggregate repeated case withsample-1andsample-2artifacts, both passing.Private evidence branch:
EntityProcess/agentv-private:evidence/av-di3a-hard-deprecate-batchat commit32995f3.Post-Deploy Monitoring & Validation
packages/core/test/evaluation/orchestrator.test.ts, provider validation tests, and CLI eval task-bundle tests.Runner-level batching was removed.sample-N/and no batch-mode fallback warnings.