fix(ci): guard eval schema generation#1725
Merged
Merged
Conversation
Deploying agentv with
|
| Latest commit: |
9167915
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c2f4bbe0.agentv.pages.dev |
| Branch Preview URL: | https://av-3uni-schema-guard.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eval schema drift is now a focused CI failure instead of a late surprise in the broad test job.
bun run validate:eval-schemaregeneratesskills-data/agentv-eval-writer/references/eval.schema.jsonfrom the Zod source, fails when that run changes the artifact, and tells workers to commit the generated diff instead of editing JSON by hand.The root package also has a direct regeneration alias, and the repo verification guidance plus schema source comments now point eval-schema authors at the root guard command.
Validation
bun install --frozen-lockfilebun run validate:eval-schemabun test packages/core/test/evaluation/validation/eval-schema-sync.test.tsbun x biome check scripts/check-eval-schema.ts package.json .github/workflows/ci.yml .agents/verification.md packages/core/src/evaluation/validation/eval-file.schema.ts packages/core/scripts/generate-eval-schema.tsbun run generate:eval-schemagit diff --checkce-code-reviewsubagent flow was not run because this tool surface only permits subagents when the user explicitly asks for delegation.Post-Deploy Monitoring & Validation
No additional operational monitoring required: this change only affects CI and local developer commands.
Healthy signal: PR CI reaches the
Check generated eval schema syncstep and passes before the broader test suite. Failure signal: that step emits the schema drift error and diff. Mitigation: runbun run validate:eval-schema, review the generated schema diff, and commit it with the Zod schema change. Validation window and owner: the next PR that touchespackages/core/src/evaluation/validation/eval-file.schema.ts, owned by that PR's author and reviewer.