Open
Conversation
octylFractal
requested changes
Apr 20, 2026
TomyLobo
force-pushed
the
fullcube-double-slabs
branch
2 times, most recently
from
a9b08cf to
96ac382
Compare
octylFractal
requested changes
Apr 29, 2026
TomyLobo
force-pushed
the
fullcube-double-slabs
branch
from
96ac382 to
0218ea0
Compare
TomyLobo
force-pushed
the
fullcube-double-slabs
branch
from
0218ea0 to
2bc7474
Compare
me4502
requested changes
May 3, 2026
| public BlockMaterial getMaterial(BlockType blockType) { | ||
| Material mat = BukkitAdapter.adapt(blockType); | ||
| public BlockMaterial getMaterial(BlockState blockState) { | ||
| Material mat = BukkitAdapter.adapt(blockState.getBlockType()); |
Member
There was a problem hiding this comment.
I'm a little unsure we can safely do this? It currently looks like this code just caches the BlockMaterial against a BlockType, using whatever BlockState is first given to it. Meaning we're not actually getting this data on a per-state basis.
I feel it should either be implemented properly to work on a per-state basis, or at the very least always use the default state rather than "whichever is passed first" for better consistency.
This excludes, for instance, rose bushes, which are #fullcube, but are visually smaller.
TomyLobo
force-pushed
the
fullcube-double-slabs
branch
from
2bc7474 to
46d5a63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.