Greptile fix on #28: render different maps per iteration#34
Open
smrifaki wants to merge 1 commit intomohit/fix-renderfrom
Open
Greptile fix on #28: render different maps per iteration#34smrifaki wants to merge 1 commit intomohit/fix-renderfrom
smrifaki wants to merge 1 commit intomohit/fix-renderfrom
Conversation
Greptile suggestion on PR #28: the loop reused the same cmd every iteration so it rendered the same map repeatedly. Add --map-name per iteration that cycles through map_NNN.bin in the training dir. Tries both 0-indexed and 1-indexed naming patterns to match different dataset conventions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Greptile bot flagged on #28: the `for map_idx in range(num_maps)` loop in `render_human_replay_videos` (pufferlib/utils.py:514) reused the same `cmd` every iteration, so it rendered the same map every time instead of different maps.
Fix
Move the cmd out of the loop as `base_cmd`, then append `--map-name` per iteration that cycles through `map_NNN.bin` in the training dir. Tries both 0-indexed (`map_000.bin`) and 1-indexed (`map_001.bin`) naming patterns to handle the dataset-naming inconsistency that PR #29 also touched (cf. PR #29 Greptile comment).
Test plan
Notes