Fix listsendpay flake#9241
Open
Lagrang3 wants to merge 2 commits into
Open
Conversation
Changelog-None Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Lagrang3
force-pushed
the
fix-listsendpay-flake
branch
from
81c6ac1 to
b65a47f
Compare
A payment attempt in listpays is defined as pair (payment hash, group id). If we query xpay for ongoing payments we must discriminate using both values. Fixes flaky test tests/test_pay.py:test_sendpay_grouping ``` FAILED tests/test_pay.py::test_sendpay_grouping - AssertionError: assert ['pending', 'pending', 'complete'] == ['failed', 'failed', 'complete'] ``` Changelog-None Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Lagrang3
force-pushed
the
fix-listsendpay-flake
branch
from
b65a47f to
232250b
Compare
Collaborator
Author
|
I ran this 10 times locally and it passes |
Lagrang3
added
the
Status::Ready for Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
listsendpays: discrimitate ongoing payment by groupid
A payment attempt in listpays is defined as pair (payment hash, group id).
If we query xpay if there are any ongoing payments we must discrimitate
using both values.
Fixes flaky test tests/test_pay.py:test_sendpay_grouping
Detected while running CI on #9228.