Add Documentation for Preload Script#1031
Open
AeonSake wants to merge 4 commits intoElectronNET:developfrom
Open
Add Documentation for Preload Script#1031AeonSake wants to merge 4 commits intoElectronNET:developfrom
AeonSake wants to merge 4 commits intoElectronNET:developfrom
Conversation
|
|
||
| if (options.isRunningBlazor) { | ||
| options.webPreferences["preload"] = path.join( | ||
| if (options.isRunningBlazor && !options.webPreferences.preload) { |
Collaborator
There was a problem hiding this comment.
Does not make sense as isRunningBlazor only exists for this.
The warning should be printed that a preload script will be ignored if isRunningBlazor is set. The option, which has been turned on explicitly, should always have preference.
Author
There was a problem hiding this comment.
Fine by me, I'll update the note in the documentation to reflect this.
FlorianRappl
requested changes
Feb 17, 2026
Author
|
This PR has been modified to only add new documentation to clarify how to handle preload scripts (and a note when using Blazor). |
AeonSake
changed the title
Collaborator
|
We could make |
pr-comment: Run #42
🎉 All tests passed!Github Test Reporter by CTRF 💚 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes for #1028
Adds a check for a user-defined preload script before manually overriding the path when running in Blazor-mode. This is technically a breaking change (since the behavior has changed) as preload scripts are now always executed. However, this most likely has no impact on existing applications as they would not have worked before this change anyway (i.e., when using a preload script in Blazor-mode).