Fixes to support building under TypeScript 5.9#4834
Fixes to support building under TypeScript 5.9#4834rbuckton wants to merge 3 commits intoEffect-TS:mainfrom
Conversation
🦋 Changeset detectedLatest commit: d427dcc The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thanks for the PR! |
|
I am running into this issue regarding HttpIncomingMessage |
Type
Description
This fixes compile-time errors discovered when running tests for updated DOM types in TypeScript 5.9. This also addresses compile-time errors resulting from a change in TypeScript 5.8 where the global
ArrayBuffertype is now distinct fromSharedArrayBufferand various typed arrays.The changes herein are primarily internal casts to a more concrete type. Avoiding the casts would require more extensive changes to effect that I would rather leave up to the maintainers. The only non-cast change is to address a bug in
HttpIncomingMessagewhich declares anarrayBufferproperty that returns an effect forArrayBuffer, but was actually returning an effect for aUint8Array.Some of the underlying errors can be seen by upgrading the version of
typescriptin the repository'spackage.json. Errors related to invalid casts to anIDBValidKeyrequire the updated DOM types from microsoft/TypeScript#61647.Related
microsoft/TypeScript#61647 (comment)