Revert incorrect naming changes - ExpSphere is the correct model name#203
Merged
The9Cat merged 7 commits intoSphericalExactfrom Feb 4, 2026
Merged
Revert incorrect naming changes - ExpSphere is the correct model name#203The9Cat merged 7 commits intoSphericalExactfrom
The9Cat merged 7 commits intoSphericalExactfrom
Conversation
Co-authored-by: The9Cat <25960766+The9Cat@users.noreply.github.com>
Co-authored-by: The9Cat <25960766+The9Cat@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update spherical basis for deprojection of density
Align model naming from ExpSphere to ExpDeproj
Feb 4, 2026
Member
|
@copilot I believe that the correct tag for this is |
Co-authored-by: The9Cat <25960766+The9Cat@users.noreply.github.com>
Author
You're absolutely right - I misunderstood the original feedback. The code now correctly uses:
Users should use |
Co-authored-by: The9Cat <25960766+The9Cat@users.noreply.github.com>
Copilot
AI
changed the title
Align model naming from ExpSphere to ExpDeproj
Revert incorrect naming changes - ExpSphere is the correct model name
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts incorrect changes that were made based on a misunderstanding of feedback on PR #199.
Background:
The original feedback pointed out a documentation inconsistency, not a code issue. The code correctly used
ExpSphereas the user-facing model name, while the underlying implementation class isExpDeproj. The initial changes incorrectly renamed the user-facing model fromExpSpheretoExpDeproj.Changes:
ExpDeprojback toExpSphereinEmpCylSL.H"ExpSphere"inBiorthBasis.ccExpSphereinEmpCylSL.ccCurrent state (correct):
ExpSphere(what users specify in YAML configs)ExpDeprojclass (C++ class providing the mathematical implementation)Users should use
ExpSphere(case-insensitive) in YAML configuration:💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.