Fix dask progress logging#3154
Open
bouweandela wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3154 +/- ##
=======================================
Coverage 96.25% 96.25%
=======================================
Files 273 273
Lines 16188 16194 +6
=======================================
+ Hits 15581 15587 +6
Misses 607 607 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the way the Dask progress loggers work:
esmvalcore.config.Sessioninstead of relying on the globalesmvalcore.config.CFGvariable, which will revert to the default in a different process, when setting up the progress bars. This fixes the issue that whenmax_parallel_tasksis set to a different value from the command line, the right kind of progress bar (Rich based if max parallel tasks = 1 and logger style if larger than 1) is not selected.I had to make quite a few changes in order to pass the session down to where logging progress is set up.
Closes #3121
Helps with #2954
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: