Skip to content

Fix dask progress logging#3154

Open
bouweandela wants to merge 1 commit into
mainfrom
fix-dask-logging
Open

Fix dask progress logging#3154
bouweandela wants to merge 1 commit into
mainfrom
fix-dask-logging

Conversation

@bouweandela

@bouweandela bouweandela commented Jul 8, 2026

Copy link
Copy Markdown
Member

Description

Update the way the Dask progress loggers work:

  • configure logging in the process from which the progress loggers are run. This fixes the issue of the progress loggers not showing.
  • pass in an esmvalcore.config.Session instead of relying on the global esmvalcore.config.CFG variable, which will revert to the default in a different process, when setting up the progress bars. This fixes the issue that when max_parallel_tasks is set to a different value from the command line, the right kind of progress bar (Rich based if max parallel tasks = 1 and logger style if larger than 1) is not selected.
  • Add a bunch of type hints

I had to make quite a few changes in order to pass the session down to where logging progress is set up.

Closes #3121
Helps with #2954


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.25%. Comparing base (0bb7e86) to head (9c3038f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3154   +/-   ##
=======================================
  Coverage   96.25%   96.25%           
=======================================
  Files         273      273           
  Lines       16188    16194    +6     
=======================================
+ Hits        15581    15587    +6     
  Misses        607      607           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bouweandela bouweandela marked this pull request as ready for review July 8, 2026 12:44
@bouweandela bouweandela requested a review from schlunma July 8, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Progress logging does not work with Dask/Distributed 2026.6

1 participant