Ensure that input arrays to scipy.interpolate.interp1d functions are C-contiguous#3151
Open
schlunma wants to merge 4 commits into
Open
Ensure that input arrays to scipy.interpolate.interp1d functions are C-contiguous#3151schlunma wants to merge 4 commits into
scipy.interpolate.interp1d functions are C-contiguous#3151schlunma wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3151 +/- ##
=======================================
Coverage 96.25% 96.25%
=======================================
Files 273 273
Lines 16188 16194 +6
=======================================
+ Hits 15581 15587 +6
Misses 607 607 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Jul 8, 2026
bouweandela
approved these changes
Jul 8, 2026
bouweandela
left a comment
Member
There was a problem hiding this comment.
Did you want to add a test? Perhaps by calling that function with an array that is not c contiguous?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensure that arrays used as input for interpolation functions created by
scipy.interpolate.interp1dare C-contiguous.Closes #3150
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: