Skip to content

Ensure that input arrays to scipy.interpolate.interp1d functions are C-contiguous#3151

Open
schlunma wants to merge 4 commits into
mainfrom
ensure_c_contiguous_arrays
Open

Ensure that input arrays to scipy.interpolate.interp1d functions are C-contiguous#3151
schlunma wants to merge 4 commits into
mainfrom
ensure_c_contiguous_arrays

Conversation

@schlunma

@schlunma schlunma commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Description

Ensure that arrays used as input for interpolation functions created by scipy.interpolate.interp1d are C-contiguous.

Closes #3150


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added this to the v2.15.0 milestone Jul 8, 2026
@schlunma schlunma requested a review from bouweandela July 8, 2026 10:43
@schlunma schlunma added the bug Something isn't working label Jul 8, 2026
@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.25%. Comparing base (0bb7e86) to head (3e151c0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3151   +/-   ##
=======================================
  Coverage   96.25%   96.25%           
=======================================
  Files         273      273           
  Lines       16188    16194    +6     
=======================================
+ Hits        15581    15587    +6     
  Misses        607      607           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bouweandela bouweandela left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to add a test? Perhaps by calling that function with an array that is not c contiguous?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Concatenation of 3D cloud data sometimes fails

2 participants