Removed check for double negative sign in custom format. Replaced by …#2270
Merged
JanKallman merged 6 commits intodevelop8from Feb 4, 2026
Merged
Removed check for double negative sign in custom format. Replaced by …#2270JanKallman merged 6 commits intodevelop8from
JanKallman merged 6 commits intodevelop8from
Conversation
…Math.Abs when formatting the string.
…tware/epplus into fix/customNumberFormat # Conflicts: # src/EPPlus/Utils/String/ValueToTextHandler.cs
swmal
pushed a commit
that referenced
this pull request
Feb 5, 2026
* WIP:Refactor * WIP:Fixed errors * WIP:Fixed more errors * Fixed broken shape drawing (bounds were not set) * Fixes issue #2254 * Ugly quick-fix shape theme colors * Added missing file * Added theme to base renderItem constructor. Added paragraph default font * WIP:Fixes for text handling in new implementation * added corrected fillcolors and paragraph spacing * Potential solve if string.Concat was the issue (#2256) * Potential solve if string.Concat was the issue * Added space * Fixed first case * Changed AddText to use DefaultParagraph instead. * Tried to fix center align. WIP * Wip:text fixes * Still two pixels off. Likely Border size * WIP:Fixed bounding boxes to tranform to inherit from transform * Merge fix * Fixed minor spelling mistake * Adjusted rectangle to not be doubled * WIP:Fixes for the Svg Textbox in differnet chart objects. * fixed endgroup for shape + minor misspelling * removed unimplemented function * Measurer from > to >= to adjust for round. + test debug * WIP:Fixes for new positioning system * Major re-write of line handling * WIP:Textbox fixes+powerquery metadata * Fixes issue #2261 * WIP:Textbox * Broken messy solution * Added more checks on the ExcelCustomXml.Save method - #2254 (#2264) * Fixed the major issues. width still wrong after 1st line * WIP:Work on auto value axis * Fixes issue #2265 (#2267) * fixed checking for negative sign when using custom number format. (#2259) * Functional non-bugged return of textLines * WIP:Added support for stacked line charts * Removed check for double negative sign in custom format. Replaced by … (#2270) * Removed check for double negative sign in custom format. Replaced by Math.Abs when formatting the string. * Added more tests * added comment * Reverted to using regexp * Added some additional checks for custom format. * EPPlus version 8.4.2 * Added functional implementation of new system * Cleanup and starting to add to addtext * Made it work for charts/regular text * WIP:Added glow effect for chart objects. * Fixed test and a few minor bugs * fixed constructor RunItem now point height --------- Co-authored-by: Jan Källman <jan.kallman@epplussoftware.com> Co-authored-by: AdrianEPPlus <162118292+AdrianEPPlus@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Math.Abs when formatting the string.
Before submitting this pull request I have...