feat: added option to set local win opts of BufferList window and option to have cursor start on current buffer line#13
Open
truthseekeraria wants to merge 2 commits intoEL-MASTOR:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i figured adding a way to set custom local window opts of the BufferList window would be a nice way to allow for more customizability if desired, such as customizing the statuscolumn for example
as for the second thing i think it just makes more sense to have the cursor start on the line of the current buffer. even if you don't intend to move navigate through the window with the cursor, if you were to enable vim.wo.cursorline through the win_opts option for the BufferList you would get a nicer more clear visual indicator for your current buffer (which is probably what i'll use it for). i also added an option to disable it as well in case people who are used to the old behaviour don't want it to work like this (although it's probably an unnecessary option, if you think having it isn't worthwhile then i could always remove it)
also btw i think you did a pretty good job of designing this thing, it's definitely my favourite buffer navigator i've tried 👍