Skip to content

fix: allow hidden collaborator emails #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roryist merged 3 commits into from
Jul 2, 2026
Merged

fix: allow hidden collaborator emails #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc87c51
fix: allow hidden collaborator emails
roryist Jun 2, 2026
cfa7d50
test: Cover hidden collaborator email via shared fixture.
roryist Jul 2, 2026
8d1b9dd
docs: Correct fixture comment to forward-compat framing.
roryist Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/data/test_defaults.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,9 @@ class PaginatedItems(TypedDict):

DEFAULT_COLLABORATOR_RESPONSE_3 = dict(DEFAULT_COLLABORATOR_RESPONSE)
DEFAULT_COLLABORATOR_RESPONSE_3["id"] = "6X7rjKtP98vG84rK"
# Forward-compat with Doist/Issues#20418: hidden collaborator emails are
# currently sent as "hidden@todoist.com", but may become null.
DEFAULT_COLLABORATOR_RESPONSE_3["email"] = None

DEFAULT_COLLABORATORS_RESPONSE: list[PaginatedResults] = [
{
Expand Down
2 changes: 1 addition & 1 deletion todoist_api_python/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ class _(JSONPyWizard.Meta): # noqa:N801
v1 = True

id: str
email: str
email: str | None
name: str


Expand Down
Loading