Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The comma-separated split of tmp.line.style ran for every chart type. Only Line supports per-series line type (Radar has no line.type parameter; other charts use a single style), and Radar/Time Series reach the per-series OutlineStyle loop - so a stray comma-separated line.type could wrongly apply per-series to them. Split only when chart.type == "Line"; still rep() to n series for all types. Mirrors how line.thickness's split is already scoped to its chart-type branch. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
chschan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of FS2-4532 — series-specific chart controls for Line chart.
Changes
getPPTSettings()now emits per-seriesOutlineStyle(line type),Marker$Size, andMarker$Style(marker symbol) for the editable-PowerPoint export, mirroring the existing per-seriesline.thickness/data.label.font.colorrecipe (ConvertCommaSeparatedStringToVector+rep(..., length=n)+[i]).markerSymbolToPPTStyle()maps plotly symbol names to PPT marker styles (circle→Circle,square→Square,diamond→Diamond,*-open→closest solid).CChartpassthrough to flipStandardCharts) is unchanged.Back-compat
Accepts both a single scalar (old Plugins) and a comma-separated string (new Plugins) for all three params.
Known limitation (accepted for this ticket)
Marker$Styleis added forchart.type == "Line"only. Radar charts not supported in PPT.Tests
469/469 (chartsettings|cchart) + 81/81 scatter suites green. New tests assert per-series values and scalar-broadcast back-compat.
Cross-repo
Companion PRs: Displayr/flipStandardCharts#132, Displayr/Plugins#FS2-4532. Manual end-to-end verification in live Displayr still pending.
🤖 Generated with Claude Code