-
-
Notifications
You must be signed in to change notification settings - Fork 261
feat: add thread info modal with rename + context usage #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vforsh
wants to merge
9
commits into
Dimillian:main
Choose a base branch
from
vforsh:feat/thread-info-rename-modal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b59fc9b
feat(threads): add thread info modal with rename and context usage
vforsh 4f030e0
fix(ui): improve copy icon visibility in thread header
vforsh 5c6cfd6
fix: shorten project field label in thread info modal
vforsh 927c0c6
fix: show project path in thread info modal
vforsh 2f38dfa
docs: add PR screenshots for thread info
vforsh a54e503
Revert "docs: add PR screenshots for thread info"
vforsh 56a4d24
fix: use first non-empty user prompt for thread title generation
vforsh bb5c1e3
fix(header): close thread info modal when thread context disappears
vforsh c435fa8
fix(thread-info): handle clipboard failures in copy actions
vforsh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because
threadInfoOpenis never cleared whenactiveThreadInfobecomes falsy, the modal can silently unmount (for example when the user navigates to workspace home or the active thread is temporarily unset) while the open flag staystrue; as soon as another thread becomes active, the modal reappears automatically without an explicit click. This creates an unexpected cross-thread modal reopen behavior that is user-visible and confusing.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in bb5c1e3. Added a
useEffectinMainHeaderto resetthreadInfoOpenwheneveractiveThreadInfobecomes falsy, so the modal cannot silently stay open and auto-reappear on a different thread context.