Fixed to remove flashes on load and on change of dark/light#246
Draft
zoharma wants to merge 1 commit into
Draft
Conversation
zoharma
force-pushed
the
zma/ds-mode-flash-fix
branch
3 times, most recently
from
49bfc8f to
ceeb4c3
Compare
- Updated load based on direction in Installation guide - Found that adding initialisation in HTML helps - updated button to reduce flashing on both onLoad and reload
zoharma
force-pushed
the
zma/ds-mode-flash-fix
branch
from
f176610 to
7b3f85b
Compare
Contributor
Author
|
I've streamlined this but there are some strange issues in the checks and tests @VictoriaBeilsten-Edmands @akademy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found there was flashing onLoad and on change light/dark mode in MRT.
Here are a number of fixes: