Add a config key to allow transfer to a single raw directory#803
Open
stephen-riggs wants to merge 2 commits into
Open
Add a config key to allow transfer to a single raw directory#803stephen-riggs wants to merge 2 commits into
stephen-riggs wants to merge 2 commits into
Conversation
stephen-riggs
requested review from
d-j-hatton and
tieneupin
and removed request for
tieneupin
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #803 +/- ##
==========================================
- Coverage 52.32% 52.30% -0.02%
==========================================
Files 96 96
Lines 10322 10327 +5
Branches 1357 1360 +3
==========================================
+ Hits 5401 5402 +1
- Misses 4642 4645 +3
- Partials 279 280 +1 🚀 New features to boost your workflow:
|
tieneupin
reviewed
May 19, 2026
| log.debug("MultigridDirWatcher thread stop completed") | ||
|
|
||
| def _handle_metadata(self, directory: Path, extra_directory: str): | ||
| def _handle_metadata(self, directory: Path, extra_directory: str, limited=True): |
Contributor
There was a problem hiding this comment.
I think _handle_subdir might be a suitable replacement name for _handle_metadata, as it seems to be notifying the notifying the subscribed components to create an additional Analyser for the sub-directory stated in extra_directory.
Contributor
Author
There was a problem hiding this comment.
Not exactly, as discussed the name is unchanged but a comment has been added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One possible option for how to resolve the b24 data transfer where we want everything to go to the same raw folder, but using different rsyncers and analysers.
This adds a config key to override the suggested path logic and return raw each time. It also turns the limited transfer behaviour off in for all rsyncers made by this method so the files are analysed.