SXT bugfixes and improvements#801
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #801 +/- ##
=======================================
Coverage 52.33% 52.34%
=======================================
Files 96 96
Lines 10324 10345 +21
Branches 1357 1363 +6
=======================================
+ Hits 5403 5415 +12
- Misses 4642 4647 +5
- Partials 279 283 +4 🚀 New features to boost your workflow:
|
stephen-riggs
requested review from
d-j-hatton and
tieneupin
and removed request for
tieneupin
| visit_index = transferred_file.parent.parts.index(environment.visit) | ||
| destination_search_dir = "/".join( | ||
| transferred_file.parent.parts[: visit_index + 2] | ||
| ).replace("//", "/") |
There was a problem hiding this comment.
.parent is not strictly needed, as the indexing and slicing should work the same on the original transferred_file variable.
tieneupin
left a comment
tieneupin
left a comment
There was a problem hiding this comment.
Some requests for clarification, but beyond that, the changes looks good. Nice work!
| txrm_ole.openstream("ImageInfo/PixelSize").getvalue(), | ||
| np.float32, | ||
| ).tolist() | ||
| metadata["pixel_size"] = pixel_size_txrm[0] * 1e4 |
There was a problem hiding this comment.
Are you converting to micrometres here?
There was a problem hiding this comment.
Looks like I set it to go from microns to angstroms. That was done in a previous PR but I guess the txrm is storing it in microns then
2 participants
Various changes needed to make the SXT workflow smoother:
DataCollectionispyb table_angleThe remaining issue is how to set the rsyncers correctly, which we need to discuss