Open
Conversation
…er FIB atlas images
* Removed previous logic for parsing 'EMproject.emxml' file, since it's no longer needed * Added class function to post to backend server to trigger FIB atlas registration
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #766 +/- ##
==========================================
+ Coverage 49.33% 49.95% +0.62%
==========================================
Files 92 94 +2
Lines 9826 9932 +106
Branches 1298 1300 +2
==========================================
+ Hits 4848 4962 +114
+ Misses 4726 4715 -11
- Partials 252 255 +3 🚀 New features to boost your workflow:
|
tieneupin
force-pushed
the
register-fib-data
branch
from
c0db7c2 to
259f65f
Compare
…age position, image field of view, and rotation
tieneupin
force-pushed
the
register-fib-data
branch
from
259f65f to
d7ab0ee
Compare
tieneupin
added
enhancement
d-j-hatton
reviewed
Mar 31, 2026
| # Metadata is stored in the TIFF file under tag number 34683 | ||
| img = PIL.Image.open(file) | ||
| tags = dict(img.tag_v2) | ||
| xml_metadata = ET.fromstring(str(tags.get(34683))) |
Contributor
There was a problem hiding this comment.
may have robustness issues with the hardcoded tag
Contributor
Author
There was a problem hiding this comment.
That's fair. I have implemented logic to look for XML metadata under that default key first before falling back to iterating across the other keys. If no XML data is found, it raises a ValueError
… in FIB atlas file if it's not found under the default key
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the components needed to begin analysing and processing FIB data.
ImagingSitetable to keep track of stage position information in the FIBActual changes to the code make up about 400 insertions and 200 deletions, with the updating and adding of tests taking up the remainder of the diff.