New sampler concepts#1058
Open
karimsayedre wants to merge 12 commits intomasterfrom
Open
Conversation
…gle Sampler global like its Triangle counterpart, we need to keep the basis around
…local coordinate system) already given and fixed. This way we can share computation between Solid Angle and Projected Solid Angle calculations Also apply the `abs` fix from the triangle
…actical Warps are broken wrong weight was getting returned and MIS weights were inconsistent. They're broken now, NaN returned as the backwardWeight
always move the scalar multiplication of a vector in a dot product outside the dot product
…lerplate, addressed comments
| const angle_t hAngle = degrees(__wrapPhi(polar.phi, symmetry)); | ||
|
|
||
| #define NBL_IES_DEF_ANGLE_ACC(T, EXPR) struct T { using value_type = angle_t; accessor_t acc; value_type operator[](uint32_t idx) NBL_CONST_MEMBER_FUNC { return EXPR; } }; | ||
| #define NBL_IES_DEF_ANGLE_ACC(T, EXPR) struct T { using value_type = angle_t; accessor_t acc; value_type operator[](uint32_t idx) NBL_CONST_MEMBER_FUNC { return EXPR; } void get(uint32_t idx, NBL_REF_ARG(value_type) val) NBL_CONST_MEMBER_FUNC { val = EXPR; } }; |
There was a problem hiding this comment.
manually test the IES viewer didn't break
Contributor
Author
There was a problem hiding this comment.
already did :)
| { | ||
| vector_t3 retval = hemisphere_t::__generate(u.xy); | ||
| const bool chooseLower = u.z > T(0.5); | ||
| const bool chooseLower = u.z > scalar_type(0.5); |
Contributor
Author
There was a problem hiding this comment.
replaced all using a regex with VS Code
… 3 enumed types (tracking, YOLO, Eytzinger)
# Conflicts: # examples_tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addressing comment from PR #1001