Skip to content

Sobol sampler benchmarks#275

Open
karimsayedre wants to merge 7 commits intomasterfrom
sobol-sampler
Open

Sobol sampler benchmarks#275
karimsayedre wants to merge 7 commits intomasterfrom
sobol-sampler

Conversation

@karimsayedre
Copy link
Copy Markdown
Contributor

No description provided.

Comment on lines +76 to +78
[[loop]]
for (uint16_t d = _static_cast<uint16_t>(0u); d < Depth; d++)
{
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to add a mode where the depths are slightly staggered per invocation.

Explanation, SER and other things like wavefront path tracing may pack ray payloads at different depths into invocations of the same subgroup, the difference won't be wild, but it will be enough for you to have to account for having to load different matrices per invocation (which tensor cores really don't like and you need to strip with subgroup ops)

You need to add push constant dependent probability of random (depending on the triple[0].z value) break out of the depth loop to simulate paths terminating early either due to miss, absorption or russian roulette and not getting refilled. IMHO best would be a linear PDF, e.g. probability at depth=0 and probability at depth=max

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants