Skip to content

Add icon for @bbk1ng/agent-orch (npm)#5067

Open
Boris Milinkovic (bbk1ng) wants to merge 1 commit into
Devolutions:mainfrom
bbk1ng:add-agent-orch-icon
Open

Add icon for @bbk1ng/agent-orch (npm)#5067
Boris Milinkovic (bbk1ng) wants to merge 1 commit into
Devolutions:mainfrom
bbk1ng:add-agent-orch-icon

Conversation

@bbk1ng

Copy link
Copy Markdown

Adds an icon entry for the npm package @bbk1ng/agent-orch, which currently shows no icon in UniGetUI.

  • Normalized ID: bbk1ng/agent-orch (scope @ stripped, / kept, lowercase)
  • Icon: square 512×512 PNG hosted in the package repo, referenced by raw URL (same pattern as existing external entries like google/gemini-cli)

Verified screenshot-database-v2.json remains valid JSON after the addition.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c1bafb5215

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

"total_screenshots": 4140
},
"icons_and_screenshots": {
"bbk1ng/agent-orch": {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use npm's scoped-package lookup key

Scoped npm package IDs are not normalized this way in the app: Npm.ParseSearchOutput stores the npm name unchanged as Package.Id (src/UniGetUI.PackageEngine.Managers.Npm/Npm.cs:243-246), and icon lookup only probes Manager.Name + "." + package.Id plus package.GetIconId() (src/UniGetUI.PackageEngine.PackageManagerClasses/Manager/Helpers/BasePkgDetailsHelper.cs:163-172). GenerateIconId replaces / with - but keeps @ (src/UniGetUI.PackageEngine.PackageManagerClasses/Packages/Package.cs:416-422), so @bbk1ng/agent-orch is looked up as Npm.@bbk1ng/agent-orch or @bbk1ng-agent-orch; this bbk1ng/agent-orch entry will not be found, leaving the package on the default icon.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants