Improve DataGrid wheel scrolling performance and error handling#5064
Merged
Gabriel Dufresne (GabrielDuf) merged 2 commits intoJul 8, 2026
Conversation
… frames The wheel-scroll easing ran on a fixed-rate DispatcherTimer whose ticks are not aligned to the display refresh, so motion juddered on the Installed/Updates lists where per-row background work keeps the UI thread busy. Advance the ease from TopLevel.RequestAnimationFrame (vsync-aligned) with time-based decay so it stays smooth at any refresh rate. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Marc-André Moreau (mamoreau-devolutions)
approved these changes
Jul 8, 2026
Gabriel Dufresne (GabrielDuf)
deleted the
fix/datagrid-wheel-scroll-judder
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to icon loading robustness and enhances the smooth scrolling experience in data grids. The most significant changes include making icon decoding more resilient to corrupted or incomplete files, and replacing the timer-based scroll animation with a more natural, frame-based easing approach.
Icon loading robustness:
TryDecodeIconhelper methods inPackageCollections.csto gracefully handle corrupted or incomplete cached icon files by catching decoding errors and logging them, preventing exceptions from surfacing.LoadIconAsyncto useTryDecodeIconfor both file and HTTP sources, ensuring null is cached when decoding fails.Data grid scroll animation improvements:
DataGridWheelAnimatorwith a frame-based approach usingRequestAnimationFrame, providing smoother and more natural easing for vertical wheel scrolling.WheelStepfor faster scrolling per notch, and introduced a time constantTaufor exponential easing, resulting in a more responsive and visually appealing glide effect.DispatcherTimerand related code, simplifying the animation logic.These changes improve both the reliability of icon display and the user experience when scrolling through data grids.