Fix log text color for dark mode and live theme switch#5060
Merged
Conversation
4 tasks
Marc-André Moreau (mamoreau-devolutions)
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves how the application handles theming for log and output views, ensuring that colors and brushes adapt correctly to theme changes (such as switching between light and dark mode) at runtime. The changes introduce a new
ThemeHelperutility, refactor brush resolution logic, and update UI components to recolor output lines dynamically when the theme changes.The most important changes are:
Theme detection and brush resolution improvements:
ThemeHelperinsrc/UniGetUI.Avalonia/Infrastructure/ThemeHelper.csto reliably determine the current theme variant and whether the app is in dark mode, resolving issues where theme detection could be inconsistent.ThemeHelperfor consistent theme resolution, replacing direct use ofApplication.Current.ActualThemeVariant.Dynamic theme switching support:
OperationOutputViewModel,OperationFailedDialog,OperationOutputWindow, andBaseLogPageto listen for theme changes (ActualThemeVariantChanged) and rebuild or reload their output lines with the correct brushes, so already-rendered output adapts instantly to theme switches.Code cleanup and reliability:
These changes make the application's log and output views more visually reliable and responsive to theme changes, addressing previous issues with incorrect colors in dark mode.