Skip to content

Scheduler — Replace underscore-prefixed: Long tail (popup, helpers, header, utils)#33009

Open
aleksei-semikozov wants to merge 2 commits intoDevExpress:26_1from
aleksei-semikozov:scheduler-underscore-long-tail
Open

Scheduler — Replace underscore-prefixed: Long tail (popup, helpers, header, utils)#33009
aleksei-semikozov wants to merge 2 commits intoDevExpress:26_1from
aleksei-semikozov:scheduler-underscore-long-tail

Conversation

@aleksei-semikozov
Copy link
Contributor

No description provided.

@aleksei-semikozov aleksei-semikozov marked this pull request as ready for review March 23, 2026 15:22
@aleksei-semikozov aleksei-semikozov requested a review from a team as a code owner March 23, 2026 15:22
Copilot AI review requested due to automatic review settings March 23, 2026 15:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR continues the Scheduler internal refactor to eliminate underscore-prefixed members by renaming them to non-underscore equivalents and (where applicable) marking them private, while updating internal call sites and a legacy scheduler test accordingly.

Changes:

  • Updated legacy Scheduler appointment popup test to use tryLockSaveChanges() instead of _tryLockSaveChanges().
  • Refactored multiple Scheduler internal modules (appointment popup, compact helper, header/calendar, table creator, appointment data source) to rename underscore-prefixed helpers/fields and adjust call sites.
  • Tightened encapsulation in several places by switching renamed members to private.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/legacyAppointmentPopup.tests.js Updates the legacy test to match the renamed appointment popup lock method.
packages/devextreme/js/__internal/scheduler/view_model/m_appointment_data_source.ts Renames internal store-key/helper initialization methods and updates internal usage.
packages/devextreme/js/__internal/scheduler/m_table_creator.ts Renames grouped-row creation helpers and marks them private, updating internal callers.
packages/devextreme/js/__internal/scheduler/m_compact_appointments_helper.ts Renames internal template/button/tooltip helper methods and marks them private.
packages/devextreme/js/__internal/scheduler/header/m_header.ts Renames underscore-prefixed header fields to private members and updates references.
packages/devextreme/js/__internal/scheduler/header/m_calendar.ts Renames underscore-prefixed overlay/calendar fields to private members and updates references.
packages/devextreme/js/__internal/scheduler/appointment_popup/m_popup.ts Renames underscore-prefixed popup helpers/handlers to private methods and updates internal references.
packages/devextreme/js/__internal/scheduler/appointment_popup/m_legacy_popup.ts Same refactor as the non-legacy popup: renames underscore-prefixed internals and updates internal usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants