DataGrid: unskip demo tests#32344
Merged
anna-shakhova merged 4 commits intoDevExpress:26_1from Feb 2, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR unskips two previously skipped DataGrid demo tests: RemoteGrouping and SignalRService. The PR updates test skip lists, improves the RemoteGrouping test implementation with better selectors and screenshot naming, modifies the SignalRService jQuery demo to wrap cell template content in wrapper divs, and changes the RemoteGrouping jQuery demo to use a different theme stylesheet.
Changes:
- Removes 'RemoteGrouping' from skipped tests in visual test matrix across all frameworks (jQuery, Angular, React, Vue)
- Removes 'SignalRService' from skipped tests configuration for Angular, React, and Vue
- Updates RemoteGrouping test with improved selectors, adds initial screenshot, and renames screenshot files for clarity
- Modifies SignalRService jQuery implementation to wrap cell template content in wrapper divs before appending to container
- Changes RemoteGrouping jQuery demo from
dx.light.csstodx.fluent.blue.light.csstheme
Reviewed changes
Copilot reviewed 4 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/demos/utils/visual-tests/matrix-test-helper.ts | Removes 'RemoteGrouping' from SKIPPED_TESTS for all frameworks (jQuery, Angular, React, Vue) |
| apps/demos/testing/skipped-tests.js | Removes 'SignalRService' from skipped tests for Angular, React, and Vue frameworks |
| apps/demos/testing/widgets/datagrid/RemoteGrouping.test.ts | Improves test with initial screenshot, better selector using .dx-datagrid-expand, and more descriptive screenshot filenames |
| apps/demos/Demos/DataGrid/SignalRService/jQuery/index.js | Wraps cell template content in wrapper divs for both price and change columns to match intended DOM structure |
| apps/demos/Demos/DataGrid/RemoteGrouping/jQuery/index.html | Changes theme stylesheet from dx.light.css to dx.fluent.blue.light.css |
Raushen
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.