fix: .cbmignore negation overrides built-in skip directories#543
Open
mvanhorn wants to merge 1 commit into
Open
fix: .cbmignore negation overrides built-in skip directories#543mvanhorn wants to merge 1 commit into
mvanhorn wants to merge 1 commit into
Conversation
Implements 2026-06-20-014-fix-cbmignore-negation-overrides-builtin-skip-dirs. Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
1 task
Owner
|
Thanks @mvanhorn — this reviewed clean and is ready (the negation-override logic is sound and well-tested). It now conflicts with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Lets a
.cbmignorenegation pattern (e.g.!obj/) un-skip a directory that is in the built-inALWAYS_SKIP_DIRSset, so users can opt a normally-skipped directory back into discovery. This ships the negation-override half of #500 the maintainer described; the joint config-key default-override (#497) is deferred.Refs #500
Checklist
git commit -s) — required, CI rejectsunsigned commits (DCO, see CONTRIBUTING.md)
make -f Makefile.cbm test)make -f Makefile.cbm lint-ci)AI was used for assistance.