fix(c-lsp): cap expression type evaluation steps#323
Open
romanornr wants to merge 1 commit intoDeusData:mainfrom
Open
fix(c-lsp): cap expression type evaluation steps#323romanornr wants to merge 1 commit intoDeusData:mainfrom
romanornr wants to merge 1 commit intoDeusData:mainfrom
Conversation
3a5e9bf to
915ccb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unknownafter the budget is exhausted instead of allowing pathological expression/type lookup loops to hang indexingWhy
While indexing a large Bitcoin-derived C++ codebase, one worker could hang indefinitely in
c_eval_expr_type()/c_eval_expr_type_inner()during definition extraction. The minimal repro was a single C++ test file with many versionbits-style checks; GDB showed repeated C++ expression evaluation through member/type lookup rather than a crash.This guard trades a small amount of precision in pathological files for keeping repository indexing bounded and useful.
Test plan
make -f Makefile.cbm test -j$(nproc)Related
Follow-up to #322, which fixes a separate C++ LSP crash path.