fix(Grainient): render initial frame in setSize to prevent flicker#929
Open
anonymousRecords wants to merge 1 commit intoDavidHDev:mainfrom
Open
fix(Grainient): render initial frame in setSize to prevent flicker#929anonymousRecords wants to merge 1 commit intoDavidHDev:mainfrom
anonymousRecords wants to merge 1 commit intoDavidHDev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Grainientcomponent flickers on mount. When the component mounts,setSize()is called to configure the canvas dimensions — butrenderer.render()only runs inside therequestAnimationFrameloop. This means the canvas stays blank for ~1 frame between mount and the first rAF tick, causing a visible flash against the page background.Root Cause
renderer.render()was only called inside the animation loop, so the canvas stays blank until the next rAF tick fires.Fix
Added renderer.render({ scene: mesh }) inside setSize() so the canvas draws immediately whenever the size is set.
This fix is applied to all 4 variants of the Grainient component (JS/TS × CSS/Tailwind).
▎ Note: The same issue exists in Plasma and other OGL-based components — a follow-up PR will address those.
Preview
AS-IS
TO-BE