Skip to content

Clarify that DATABASE_URL can not be empty if allowlist is used #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abitrolly wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −3
Open

Clarify that DATABASE_URL can not be empty if allowlist is used #728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions README.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ DatabaseCleaner.allow_production = true
DatabaseCleaner.allow_remote_database_url = true
```

In Ruby, a URL allowlist can be specified. When specified, DatabaseCleaner will only allow `DATABASE_URL` to be equal
In Ruby, a URL allowlist can be specified. When specified, DatabaseCleaner will require `DATABASE_URL` to be set and equal
to one of the values specified in the url allowlist like so:

```ruby
Expand All @@ -348,8 +348,9 @@ Allowlist elements are matched with case equality (`===`), so regular expression

```ruby
DatabaseCleaner.url_allowlist = [
%r{^postgres://postgres@localhost}, # match any db with this prefix
proc {|uri| URI.parse(uri).user == "test" } # match any db authenticating with the 'test' user
%r{^postgres://postgres@localhost}, # match any db with this prefix
proc {|uri| URI.parse(uri).user == "test" }, # match any db authenticating with the 'test' user
nil # allow DATABASE_URL to be unset
]
```

Expand Down
Loading