[WIP] add pre-signal state check for wallclock#502
Draft
Conversation
Contributor
CI Test ResultsRun: #25169296748 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Summary: Total: 32 | Passed: 32 | Failed: 0 Updated: 2026-04-30 14:40:16 UTC |
da37425 to
06136e1
Compare
1e61333 to
4523b4a
Compare
0ad95a4 to
3e231a0
Compare
3e231a0 to
28856f4
Compare
d71b9e2 to
24fec34
Compare
24fec34 to
81c7712
Compare
476e957 to
aef1748
Compare
aef1748 to
c45d4d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Adds a pre-signal check to the wall-clock timer loop that reads the OS thread state before sending a signal. When a thread is in SLEEPING state, the signal is skipped.
Motivation:
The wall-clock profiler sends a signal to every tracked thread at ~1ms intervals. For threads blocked, this generates up to 1000 signals/second that all produce the same stack, and the profiler learns nothing new from repeated samples. At large scale, we observe undesirable effects like signal storms, cache thrashing or sample distortion. Skipping those signals reduces unnecessary overhead without losing meaningful profiling data.
Additional Notes:
How to test the change?:
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!