Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .circleci/Dockerfile-openjdk7

This file was deleted.

91 changes: 0 additions & 91 deletions .circleci/config.yml

This file was deleted.

64 changes: 64 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
name: CI

on:
push:
pull_request:

jobs:
test:
name: Test (Java ${{ matrix.java-version }}, ${{ matrix.os }})
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest]
java-version: ['7', '8', '11', '13', '17']
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Drop Java 7 from matrix or pin a Java-7-compatible Maven

Including java-version: '7' in this matrix will make the new GitHub Actions job fail before tests run, because ubuntu-latest runners currently ship Maven 3.9.x while Maven 3.9 requires JDK 8+ to execute. This workflow invokes plain mvn for every matrix entry, so the Java 7 leg is effectively broken unless you install/pin an older Maven (or use a wrapper) specifically for that leg.

Useful? React with 👍 / 👎.

include:
- os: windows-latest
java-version: '12'
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654 # v5.2.0
with:
java-version: ${{ matrix.java-version }}
distribution: zulu
cache: maven
- name: Build and test
run: mvn clean install
- name: Build and test dogstatsd-http-core
run: mvn clean install
working-directory: dogstatsd-http-core

test-jnr-exclude:
name: Test (Java 8, jnr-exclude)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654 # v5.2.0
with:
java-version: '8'
distribution: zulu
cache: maven
- name: Build and test (jnr-exclude)
run: mvn clean test -P jnr-exclude
- name: Build and test dogstatsd-http-core
run: mvn clean install
working-directory: dogstatsd-http-core

test-jnr-latest:
name: Test (Java 8, jnr-latest)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654 # v5.2.0
with:
java-version: '8'
distribution: zulu
cache: maven
- name: Build with default dependencies
run: mvn clean install
- name: Test with latest jnr dependencies
run: mvn test -P jnr-latest
- name: Build and test dogstatsd-http-core
run: mvn clean install
working-directory: dogstatsd-http-core
Loading