Migrate 10 more integrations to mock_http#23536
Open
mwdd146980 wants to merge 13 commits intomwdd146980/httpx-migration-basefrom
Open
Migrate 10 more integrations to mock_http#23536mwdd146980 wants to merge 13 commits intomwdd146980/httpx-migration-basefrom
mwdd146980 wants to merge 13 commits intomwdd146980/httpx-migration-basefrom
Conversation
🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 4a95df5 | Docs | Datadog PR Page | Give us feedback! |
ed45ae6 to
d8f7ab2
Compare
9709aed to
7e8968a
Compare
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
d8f7ab2 to
6ba89ee
Compare
362e3dd to
573ae6c
Compare
6ba89ee to
218ea72
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
sblumenthal
approved these changes
May 1, 2026
Base automatically changed from
mwdd146980/step4-conftest-session-patches
to
mwdd146980/httpx-migration-base
May 1, 2026 15:59
80a7ee1 to
b4c8301
Compare
…ertion per PR 22676 marathon precedent
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
b4c8301 to
4a95df5
Compare
Contributor
Validation ReportAll 20 validations passed. Show details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
Step 5 of the Test Decoupling Plan. Eliminate direct
requests.Session.*patches in test files so tests are decoupled from the HTTP backend. Part of the httpx migration.Approach
Per-integration migration to the
mock_httpfixture (introduced in #22676), one commit per integration. PR #22676 precedent followed for assertion rewrites. Drop boilerplate kwargs and assert only the contract being tested.powerdns_recursor'stest_metadata_unitwas split into three focused tests with a_make_check()helper. The original sequenced three sub-cases sharing onemock_http.getwith asymmetricreset_mockcalls. That structure makes it hard to add new sub-cases without breaking existing ones. Migrating the file was a fitting cleanup window since every assertion line was already being touched.For full details, see the PR 5.1 plan page.
Verification
mwdd146980/httpx-migration-base(this PR stacks on Feature branch for httpx migration #22676)ddev test -fs <intg>+ddev --no-interactive test --recreate <intg>per integration🤖 Generated with Claude Code