Continuously integrate libdatadog via scheduled job#3830
Continuously integrate libdatadog via scheduled job#3830
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a99a44fe5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 77cab62 | Docs | Datadog PR Page | Give us feedback! |
1a99a44 to
77cab62
Compare
Benchmarks [ tracer ]Benchmark execution time: 2026-04-24 19:41:10 Comparing candidate commit 77cab62 in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 191 metrics, 1 unstable metrics. scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache
scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
|
| dd-octo-sts token --scope DataDog/dd-trace-php --policy gitlab-ci-libdatadog-latest > tmp/github_token.txt | ||
| GITHUB_TOKEN=$(cat tmp/github_token.txt) | ||
| export GITHUB_TOKEN GH_TOKEN="${GITHUB_TOKEN}" |
There was a problem hiding this comment.
| dd-octo-sts token --scope DataDog/dd-trace-php --policy gitlab-ci-libdatadog-latest > tmp/github_token.txt | |
| GITHUB_TOKEN=$(cat tmp/github_token.txt) | |
| export GITHUB_TOKEN GH_TOKEN="${GITHUB_TOKEN}" | |
| GITHUB_TOKEN=$(dd-octo-sts token --scope DataDog/dd-trace-php --policy gitlab-ci-libdatadog-latest) | |
| export GITHUB_TOKEN GH_TOKEN="${GITHUB_TOKEN}" |
We may want to avoid having to write token to disk just in case
| after_script: | ||
| - if [[ -f tmp/github_token.txt ]]; then dd-octo-sts revoke -t "$(cat tmp/github_token.txt)" || true; fi |
There was a problem hiding this comment.
| after_script: | |
| - if [[ -f tmp/github_token.txt ]]; then dd-octo-sts revoke -t "$(cat tmp/github_token.txt)" || true; fi |
Not needed if we don't write token to disk
| claude \ | ||
| --allowedTools "Read,Glob,Grep,Edit,Write" \ | ||
| --permission-mode bypassPermissions \ | ||
| --max-turns 50 \ | ||
| -p "${PROMPT_CONTEXT} |
There was a problem hiding this comment.
should we restrict accessible directories to ensure Claude is not messing with files other than libdatadog / dd-trace-php ?
Adding a pipeline which will be called on
masterwithSCHEDULED_LIBDATADOG_LATEST=truevariable every night.This makes sure that we get early / quick insights when a change on libdatadog breaks the dd-trace-php build:
It works, see https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/jobs/1629546146. Also see the attached artifact, which claude generated on that pipeline:
The octo sts token permissions are still missing on master, so can't test pushing yet, but at least it gets right up to that point.