Skip to content

test(profiling): add missing prof correctness tests for I/O profiling#3652

Open
realFlowControl wants to merge 2 commits intomasterfrom
florian/macos-io-profiling-tests
Open

test(profiling): add missing prof correctness tests for I/O profiling#3652
realFlowControl wants to merge 2 commits intomasterfrom
florian/macos-io-profiling-tests

Conversation

@realFlowControl
Copy link
Member

@realFlowControl realFlowControl commented Feb 16, 2026

Description

This PR adds missing I/O correctness tests

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@github-actions github-actions bot added the profiling Relates to the Continuous Profiler label Feb 16, 2026
@pr-commenter
Copy link

pr-commenter bot commented Feb 16, 2026

Benchmarks [ profiler ]

Benchmark execution time: 2026-03-02 09:28:48

Comparing candidate commit afbae12 in PR branch florian/macos-io-profiling-tests with baseline commit 6733f8f in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 28 metrics, 8 unstable metrics.

@realFlowControl realFlowControl force-pushed the florian/macos-io-profiling-tests branch from b198600 to 5d690e5 Compare February 16, 2026 16:31
@realFlowControl realFlowControl marked this pull request as ready for review February 16, 2026 16:37
@realFlowControl realFlowControl requested review from a team as code owners February 16, 2026 16:37
@realFlowControl realFlowControl force-pushed the florian/macos-io-profiling-tests branch from 5d690e5 to 941d06e Compare February 16, 2026 16:40
@datadog-official
Copy link

datadog-official bot commented Feb 16, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 1028 Tests failed

testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Datadog) (Fix with Cursor)
Risky Test
phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:52
testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Datadog) (Fix with Cursor)
Risky Test
phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:97
testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 69a5571d00000000dbc35570564fc45a
tid: 69a5571d00000000
hexProcessTraceId: dbc35570564fc45a
hexProcessSpanId: d107a567beec0e13
processTraceId: 15835594655737562202
processSpanId: 15062189343767268883
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: afbae12 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@realFlowControl realFlowControl force-pushed the florian/macos-io-profiling branch 3 times, most recently from e32fa5d to 6bac2fd Compare February 18, 2026 06:19
@realFlowControl realFlowControl force-pushed the florian/macos-io-profiling-tests branch 2 times, most recently from 13fbf30 to 3bee471 Compare February 18, 2026 06:29
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.08%. Comparing base (6733f8f) to head (afbae12).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3652      +/-   ##
==========================================
- Coverage   62.20%   62.08%   -0.12%     
==========================================
  Files         141      141              
  Lines       13352    13352              
  Branches     1746     1746              
==========================================
- Hits         8305     8290      -15     
- Misses       4256     4269      +13     
- Partials      791      793       +2     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6733f8f...afbae12. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@realFlowControl realFlowControl force-pushed the florian/macos-io-profiling-tests branch from 3bee471 to 17c1398 Compare February 18, 2026 06:50
@realFlowControl realFlowControl force-pushed the florian/macos-io-profiling-tests branch from 5c57467 to afbae12 Compare March 2, 2026 09:11
@realFlowControl realFlowControl requested review from a team as code owners March 2, 2026 09:11
@realFlowControl realFlowControl changed the base branch from florian/macos-io-profiling to master March 2, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

profiling Relates to the Continuous Profiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants