Skip to content

Quickwin: remove unneded strictTraceWrites overrides #11765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amarziali wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Quickwin: remove unneded strictTraceWrites overrides #11765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions dd-java-agent/instrumentation/mule-4.5/src/test/groovy/mule4/MuleForkedTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,6 @@ import spock.lang.Shared

class MuleForkedTest extends WithHttpServer<MuleTestContainer> {

// TODO since mule uses reactor core, things sometime propagate to places where they're not closed
@Override
boolean useStrictTraceWrites() {
return false
}

@Override
protected void configurePreAgent() {
super.configurePreAgent()
Expand Down
6 changes: 0 additions & 6 deletions dd-java-agent/instrumentation/mule-4.5/src/test/groovy/mule4/MuleHttpServerForkedTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,6 @@ import spock.lang.Shared

class MuleHttpServerForkedTest extends HttpServerTest<MuleTestContainer> {

// TODO since mule uses reactor core, things sometime propagate to places where they're not closed
@Override
boolean useStrictTraceWrites() {
return false
}

@Override
boolean testRedirect() {
// Dynamic adding of headers to and HttpResponse from inside a mule application seems
Expand Down
6 changes: 0 additions & 6 deletions ...umentation/opensearch/opensearch-rest-1.0/src/test/groovy/OpensearchRestClientTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,6 @@ class OpensearchRestClientTest extends InstrumentationSpecification {
@Shared
RestClient client

@Override
boolean useStrictTraceWrites() {
//FIXME IDM
false
}

def setupSpec() {

aosWorkingDir = File.createTempDir("test-aos-working-dir-", "")
Expand Down
6 changes: 0 additions & 6 deletions ...ation/opensearch/opensearch-transport-1.0/src/test/groovy/OpensearchNodeClientTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,6 @@ class OpensearchNodeClientTest extends InstrumentationSpecification {

def client = testNode.client()

@Override
boolean useStrictTraceWrites() {
//FIXME IDM
false
}

@Override
protected void configurePreAgent() {
super.configurePreAgent()
Expand Down
Loading