Cover continuation and listener behaviour when registering no-op manager during tests#11762
Open
mcculls wants to merge 2 commits into
Open
Cover continuation and listener behaviour when registering no-op manager during tests#11762mcculls wants to merge 2 commits into
mcculls wants to merge 2 commits into
Conversation
…ger during tests.
…Impl (couple of branches involve a nanosecond CAS race that can't be reliably reproduced)
mcculls
added
tag: no release notes
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
PerfectSlayer
approved these changes
Jun 29, 2026
PerfectSlayer
left a comment
PerfectSlayer
left a comment
Contributor
There was a problem hiding this comment.
Looking good for the test changes but I would rather have @bric3 to review impact of afterEvaluate use 🙏
| extra["excludedClassesBranchCoverage"] = | ||
| listOf("datadog.context.ThreadLocalContextManager.ContextContinuationImpl") | ||
|
|
||
| afterEvaluate { |
Contributor
There was a problem hiding this comment.
Requesting review from @bric3 about afterEvaluate usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Get
./gradlew :components:context:checkto pass locallyContributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)Jira ticket: [PROJ-IDENT]